Thanks for the review!
Pushed to master with the suggested changes,
Jarno
> On May 18, 2016, at 3:40 PM, Ben Pfaff <b...@ovn.org> wrote:
>
> On Tue, May 17, 2016 at 07:35:56PM -0700, Jarno Rajahalme wrote:
>> Add the missing NAT documentation to ovs-ofctl man page and add
>> validation of the NAT flags to NAT action decoding and parsing.
>>
>> Signed-off-by: Jarno Rajahalme <ja...@ovn.org>
>
> Thanks! This will make life easier for users.
>
> I see a doubled "are" in the message here:
>> + if (on->flags & NX_NAT_F_PROTO_HASH && on->flags &
>> NX_NAT_F_PROTO_RANDOM) {
>> + return xasprintf("Both \"hash\" and \"random\" are are not
>> allowed.");
>> + }
>> +
>> return NULL;
>> }
>
> In the documentation, usually we write variables that must be filled in
> by the user in italics, with \fI, here and in the running text that
> follows:
> +.IP
> \fBnat\fR[\fB(\fR(\fBsrc\fR|\fBdst\fR)\fB=\fRaddr1[\fB-\fRaddr2][\fB:\fRport1[\fB-\fRport2]][\fB,\fRflags]\fB)\fR]
>
> Probably the - should be inside the [] in each of the cases below:
> +.IP addr1-[addr2]
> +.IP port1-[port2]
>
> s/also has/also/ in the second line below:
> +If an \fBalg\fR is specified for the committing \fBct\fR action that
> +also has includes \fBnat\fR with a \fBsrc\fR or \fBdst\fR attribute,
>
> Acked-by: Ben Pfaff <b...@ovn.org>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
