Hi Jesse, Thanks so much for the review! Somehow I didn't get your "previous" email about checksum. Can you send it again? I'll address format the commit message according to your suggestions. Thanks again!
Best regards, Yin Lin ________________________________________ From: Jesse Gross <[email protected]> Sent: Thursday, May 19, 2016 5:43 PM To: Yin Lin Cc: ovs dev Subject: Re: [ovs-dev] [PATCH 3/3] [PATCH v3] Add Geneve support in Windows datapath On Thu, May 19, 2016 at 2:49 PM, Yin Lin <[email protected]> wrote: > --- > datapath-windows/ovsext/Actions.c | 82 +++----- > datapath-windows/ovsext/Debug.h | 1 + > datapath-windows/ovsext/DpInternal.h | 29 ++- > datapath-windows/ovsext/Flow.c | 171 ++++++++++++++-- > datapath-windows/ovsext/Flow.h | 7 + > datapath-windows/ovsext/Geneve.c | 355 > +++++++++++++++++++++++++++++++++ > datapath-windows/ovsext/Geneve.h | 122 +++++++++++ > datapath-windows/ovsext/Gre.c | 8 +- > datapath-windows/ovsext/Stt.c | 2 +- > datapath-windows/ovsext/Tunnel.c | 3 +- > datapath-windows/ovsext/Util.h | 1 + > datapath-windows/ovsext/Vport.c | 23 ++- > datapath-windows/ovsext/Vport.h | 10 +- > datapath-windows/ovsext/ovsext.vcxproj | 2 + > 14 files changed, 724 insertions(+), 92 deletions(-) > create mode 100644 datapath-windows/ovsext/Geneve.c > create mode 100644 datapath-windows/ovsext/Geneve.h These patches also need a signed-off-by line. Please see CONTRIBUTING.md for the format and what this means. I also had some additional comments (beyond the initial ones about the checksums) that I sent in a previous message. Please take a look. As Nithin mentioned, it would also be helpful if you provide a list of what changed between revisions of the patches to let reviewers know what you have done in response to their comments. You can do this on each patch by adding three dashes after the commit message and then your comments. This will cause the history to not be included in the final commit message when the patch is applied. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
