>-----Original Message----- >From: Flavio Leitner [mailto:f...@sysclose.org] >Sent: Tuesday, May 31, 2016 10:04 PM >To: Bodireddy, Bhanuprakash <bhanuprakash.bodire...@intel.com> >Cc: dev@openvswitch.org; Traynor, Kevin <kevin.tray...@intel.com> >Subject: Re: [ovs-dev] [PATCH 2/2] doc: Refactor DPDK install guide, add >ADVANCED doc > > >This looks very good and I just have two minor comment below. > >On Thu, May 26, 2016 at 01:46:43PM +0100, Bhanuprakash Bodireddy wrote: >> Add INSTALL.DPDK-ADVANCED document that is forked off from original >> INSTALL.DPDK guide. This document is targeted at users looking for >> optimum performance on OVS using dpdk datapath. >> >> Signed-off-by: Bhanuprakash Bodireddy >> <bhanuprakash.bodire...@intel.com> >> --- >[...] > >> + 5. Running sample "dpdk ring" app in VM >> + >> + ``` >> + umount /dev/hugepages >> + mount -t hugetlbfs hugetlbfs /mnt/hugepages >> + ln -s /sys/devices/pci0000:00/0000:00:04.0/resource2 >/dev/hugepages/rtemap_0 >> + mount -o iocharset=utf8 /dev/sdb1 /mnt/ovs >> + cp /mnt/ovs/.rte_config /run/. >> + cp /mnt/ovs/.rte_hugepage_info /run/. >> + >> + # Build the DPDK ring application in the VM >> + export RTE_SDK=/root/dpdk-16.04 >> + export RTE_TARGET=x86_64-ivshmem-linuxapp-gcc >> + make >> + >> + # Run dpdkring application >> + ./build/dpdkr -c 1 -n 4 --proc-type=secondary -- -n 0 >> + where "-n 0" refers to ring '0' i.e dpdkr0 >> + ``` >> + >> +## <a name="vhost"></a> 6. Vhost Walkthrough >> + >> +DPDK 16.04 supports two types of vhost: >> +1. vhost-user - enabled default >> +2. vhost-cuse - Legacy, disabled by default > >That doesn't show nicely on the web. They are all in the same line.
You are right, I will correct this. > >The same comment for the previous patch about the mount command in >''Mount huge pages'' here. Just add 'if not mounted' or something like that. Agree, Will add this. Thanks Flavio for reviewing the ADVANCED guide. Regards, Bhanu Prakash. > >Thanks, >-- >fbl _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev