On Thu, May 26, 2016 at 4:29 PM, Jarno Rajahalme <ja...@ovn.org> wrote:
> A netlink notifier ('nln') already supports multiple notifiers. This
> patch allows each of these notifiers to subscribe to a different
> multicast group. Sharing a single socket for multiple event types
> (each on their own multicast group) provides serialization of events
> when reordering of different event types could be problematic. For
> example, if a 'create' event and 'delete' event are on different
> netlink multicast group, we may want to process those events in the
> order in which kernel issued them, rather than in the order we happen
> to check for them.
>
> Moving the multicast group argument from nln_create() to
> nln_notifier_create() allows each notifier to specify a different
> multicast group. The parse callback needs to identify the group the
> message belonged to by returning the corresponding group number, or 0
> when an parse error occurs.
>
> Signed-off-by: Jarno Rajahalme <ja...@ovn.org>
I am getting following warning.
tests/test-netlink-conntrack.c: In function ‘event_parse’:
tests/test-netlink-conntrack.c:50:1: error: control reaches end of
non-void function [-Werror=return-type]
}
other than this and comments from Cascardo, the patch looks good to me.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
