On Tue, Jun 07, 2016 at 08:41:13AM -0700, Ben Pfaff wrote:
> On Wed, Jun 01, 2016 at 01:30:40PM -0400, Aaron Conole wrote:
> > Currently, there is some documentation which describes setting up and
> > using port mirrors for bridges. This documentation is helpful to setup
> > a packet capture for specific ports.
> > 
> > However, a utility to do such packet capture would be valuable, both
> > as an exercise in documenting the steps an additional time, and as a way
> > of providing an out-of-the-box experience for running a capture.
> > 
> > This commit adds a tcpdump-wrapper utility for such purpose. It uses the
> > Open vSwitch python library to add/remove ports and mirrors to/from the
> > Open vSwitch database. It will create a tcpdump instance listening on
> > the mirror port (allowing the user to specify additional arguments), and
> > dump data to the screen (or otherwise).
> > 
> > Signed-off-by: Aaron Conole <acon...@redhat.com>
> 
> This is pretty cool but I don't feel up to reviewing this much Python.
> Anyone else want to take a shot at it?  Alternatively, if no one does,
> then I'm willing to just take it as-is since it's so independent of
> everything else and therefore low risk.

I am in the same situation.

The tool works for me with tcpdump (default) or tshark, on a dpdk
port, vhost-user port or internal port (ovs bridge).  I also tested
with custom installation and noticed no issues.

The only issue I found is that it breaks rpm build because the tool
is neither packaged nor excluded.  I spoke with Aaron offline and he
will follow up with a fix.  I will wait for that before ACK this one.

-- 
fbl

_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to