Hi Yin, Thanks a lot for the patch, and welcome to the team :).
Please try to limit lines to 79 characters per coding style (https://github.com/openvswitch/ovs/blob/master/datapath-windows/CodingStyle). Your patch is dependent on a patch that Nithin sent http://openvswitch.org/pipermail/dev/2016-June/072138.html (http://patchwork.ozlabs.org/patch/629912/), in this case I think it is best to wait for it to merge or maybe create a patch set together. Please try to compile the patch before sending it. After applying the patch and trying to compile it we get the following: " Actions.c(693): error C4013: 'OvsEncapGeneve' undefined; assuming extern returning int Vport.c(696): error C2220: warning treated as error Vport.c(696): warning C4100: 'ovsPortType' : unreferenced formal parameter Vport.c(708): error C2059: syntax error : 'return' [c:\_2016\june\14\ovs\datapath-windows\ovsext\ovsext.vcxproj] Vport.c(709): error C2059: syntax error : '}' [c:\_2016\june\14\ovs\datapath-windows\ovsext\ovsext.vcxproj] Vport.c(1060): error C4013: 'OvsInitGeneveTunnel' undefined; assuming extern returning int [c:\_2016\june\14\ovs\datapath-windows\ovsext\ovsext.vcx proj] Vport.c(1290): error C4013: 'OvsCleanupGeneveTunnel' undefined; assuming extern returning int [c:\_2016\june\14\ovs\datapath-windows\ovsext\ovsext. vcxproj] Vport.c(2256): error C2065: 'GENEVE_UDP_PORT' : undeclared identifier [c:\_2016\june\14\ovs\datapath-windows\ovsext\ovsext.vcxproj] Vport.c(2256): warning C4242: '=' : conversion from 'int' to 'UINT16', possible loss of data [c:\_2016\june\14\ovs\datapath-windows\ovsext\ovsext.v cxproj] " I see you are changing code in Stt.c and Gre.c which are out of the scope of your current commit. Try to split them and send them in a different patch. Please add a commit message to the patch. Looking forward to v7. Thanks, Alin. > -----Mesaj original----- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Yin Lin > Trimis: Monday, June 13, 2016 11:39 PM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH v6] datapath-windows: Add Geneve support > > Signed-off-by: Yin Lin <li...@vmware.com> > --- > datapath-windows/automake.mk | 2 + > datapath-windows/ovsext/Actions.c | 74 ++----- > datapath-windows/ovsext/Debug.h | 1 + > datapath-windows/ovsext/DpInternal.h | 29 ++- > datapath-windows/ovsext/Flow.c | 173 ++++++++++++++-- > datapath-windows/ovsext/Flow.h | 7 + > datapath-windows/ovsext/Geneve.c | 361 > +++++++++++++++++++++++++++++++++ > datapath-windows/ovsext/Geneve.h | 122 +++++++++++ > datapath-windows/ovsext/Gre.c | 7 +- > datapath-windows/ovsext/Stt.c | 2 +- > datapath-windows/ovsext/Util.h | 1 + > datapath-windows/ovsext/Vport.c | 19 +- > datapath-windows/ovsext/ovsext.vcxproj | 2 + > 13 files changed, 715 insertions(+), 85 deletions(-) create mode 100644 > datapath-windows/ovsext/Geneve.c create mode 100644 datapath- > windows/ovsext/Geneve.h > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
