"dev" <dev-boun...@openvswitch.org> wrote on 06/16/2016 04:56:55 AM:
> From: Yusheng Wang <yshw...@vmware.com> > To: "dev@openvswitch.org" <dev@openvswitch.org> > Date: 06/16/2016 04:57 AM > Subject: [ovs-dev] [PATCH] OVN: initial patch of datalog engine > Sent by: "dev" <dev-boun...@openvswitch.org> > > From 62dc90f8f0a61181754e944f2101951afbd055c1 Mon Sep 17 00:00:00 2001 > From: Yusheng Wang <yshw...@vmware.com> > Date: Thu, 16 Jun 2016 15:04:26 +0800 > Subject: [PATCH] OVN: initial patch of datalog engine This commit message is too bare for a commit this size. Please provide some content for later readers that aren't up to speed with the technology being introduced here. Because the patch is so big, I'm not including my comments in-line, I'm going to put them all here: I know there was a separate patch for the ovn-datalog man patch, I think that patch should be folded into this one for a more atomic approach. Note: the log_ prefix is already used in lib/util.h and while this patch introduces a private include file, I'd be more comfortable if the log_ prefix were replaced with _datalog_ to be more consistent with the ovs naming convention. Similarly, this patch overloads other prefixes that are used elsewhere - I'd consider cleaning up the prefix usage to avoid confusion later on. Nit: is there any reason why ENT_* values 0x0c through 0x0f aren't in numerical order like the entries from 0 to 0x0b appear to be? Nit (found in multiple places): comments should begin with a capital letter and end with a period Also, I'm thinking that the datalog source file should be broken into multiple files rather than concatenated together (as it is over 3K lines long) Lastly, this patch set has a collision in the automake.mk file with the current master and so could use a rebase. Ryan Moats _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
