Thanks for incorporating the comments: Acked-by: Alin Gabriel Serdean <[email protected]>
> -----Mesaj original----- > De la: dev [mailto:[email protected]] În numele Nithin Raju > Trimis: Friday, June 17, 2016 8:52 PM > Către: [email protected] > Subiect: [ovs-dev] [PATCH v4] datapath-windows: use ip proto for tunnel > port lookup > > In Actions.c, based on the IP Protocol type and L4 port of the outer packet, > we lookup the tunnel port. The function that made this happen took the > tunnel type as an argument. > Semantically, is is better to pass the IP protocol type and let the lookup > code > map IP protocol type to tunnel type. > > In the vport add code, we make sure that we block tunnel port addition if > there's already a tunnel port that uses the same IP protocol type and L4 port > number. > > Signed-off-by: Nithin Raju <[email protected]> > Acked-by: Sairam Venugopal <[email protected]> > Acked-by: Yin Lin <[email protected]> > --- > datapath-windows/ovsext/Actions.c | 42 ++++++++++++------------- > datapath-windows/ovsext/Tunnel.c | 6 ++-- > datapath-windows/ovsext/Vport.c | 64 > +++++++++++++++++++++++++++++++++++++-- > datapath-windows/ovsext/Vport.h | 9 ++++-- > 4 files changed, 91 insertions(+), 30 deletions(-) > > diff --git a/datapath-windows/ovsext/Actions.c b/datapath- > windows/ovsext/Actions.c > index 72ebc04..7ac6bb7 100644 > --- a/datapath-windows/ovsext/Actions.c > +++ b/datapath-windows/ovsext/Actions.c > @@ -215,32 +215,32 @@ OvsDetectTunnelRxPkt(OvsForwardingContext > *ovsFwdCtx, > /* XXX: we should also check for the length of the UDP payload to pick > * packets only if they are at least VXLAN header size. > */ > + > + /* > + * For some of the tunnel types such as GRE, the dstPort is not > applicable > + * since GRE does not have a L4 port. We use '0' for convenience. > + */ _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
