Sai, There¹s not correctness issue with the existing code. There are 2 fields in pktMdLabel, and they are being set in the function. Do you see any correctness issues?
-- Nithin -----Original Message----- From: dev <[email protected]> on behalf of Sairam Venugopal <[email protected]> Date: Friday, June 24, 2016 at 6:16 PM To: "[email protected]" <[email protected]> Subject: [ovs-dev] [PATCH] datapath-windows: Conntrack - Fix variable initialization >Initialize the variable pktMdLabel. > >Signed-off-by: Sairam Venugopal <[email protected]> >--- > datapath-windows/ovsext/Conntrack.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/datapath-windows/ovsext/Conntrack.c >b/datapath-windows/ovsext/Conntrack.c >index ebfdeef..bb28b65 100644 >--- a/datapath-windows/ovsext/Conntrack.c >+++ b/datapath-windows/ovsext/Conntrack.c >@@ -500,7 +500,7 @@ OvsConntrackSetLabels(OvsFlowKey *key, > struct ovs_key_ct_labels *val, > struct ovs_key_ct_labels *mask) > { >- ovs_u128 v, m, pktMdLabel; >+ ovs_u128 v, m, pktMdLabel = {0}; > memcpy(&v, val, sizeof v); > memcpy(&m, mask, sizeof m); > >-- >2.5.0.windows.1 > >_______________________________________________ >dev mailing list >[email protected] >https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailma >n_listinfo_dev&d=CwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=pN >HQcdr7B40b4h6Yb7FIedI1dnBsxdDuTLBYD3JqV80&m=eoy2XpJIpS2H0d5a5h8cdT5HzcVrIX >SMvsEnv2anmBE&s=qAcvDtyPrDy99WdgB1keL3C6CXI9NXvTT0UwAmyxlm8&e= _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
