Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Jun 22, 2016, at 6:00 PM, Joe Stringer <j...@ovn.org> wrote: > > For many of the tests, we would first execute a "basic connectivity > check" to validate the sanity of the setup before running the test > traffic which probes the actual OVS behaviour. However, by running > traffic through the rules prior to running the test, it is more likely > that the traffic hits datapath flows and doesn't test the "execute" path > (from userspace to kernel). This can hide some classes of bugs. > > The first few tests in system-traffic already check the basic sanity of > the environment, so these redundant pieces are unnecessary. Remove them. > > Signed-off-by: Joe Stringer <j...@ovn.org> > --- > tests/system-traffic.at | 33 --------------------------------- > 1 file changed, 33 deletions(-) > > diff --git a/tests/system-traffic.at b/tests/system-traffic.at > index 5ce395554500..a4ca12e2385d 100644 > --- a/tests/system-traffic.at > +++ b/tests/system-traffic.at > @@ -314,9 +314,6 @@ priority=100,in_port=2,ct_state=+trk+est,tcp,action=1 > > AT_CHECK([ovs-ofctl --bundle add-flows br0 flows.txt]) > > -dnl Basic connectivity check. > -NS_CHECK_EXEC([at_ns0], [ping -q -c 3 -i 0.3 -w 2 10.1.1.2 >/dev/null]) > - > dnl HTTP requests from ns0->ns1 should work fine. > NETNS_DAEMONIZE([at_ns1], [[$PYTHON $srcdir/test-l7.py]], [http0.pid]) > NS_CHECK_EXEC([at_ns0], [wget 10.1.1.2 -t 3 -T 1 --retry-connrefused -v -o > wget0.log]) > @@ -1366,11 +1363,6 @@ > priority=100,in_port=2,ct_state=+trk+est-new,icmp,action=1 > > AT_CHECK([ovs-ofctl --bundle add-flows br0 flows.txt]) > > -dnl Basic connectivity check. > -NS_CHECK_EXEC([at_ns0], [ping -q -c 3 -i 0.3 -w 2 10.1.1.2 | FORMAT_PING], > [0], [dnl > -3 packets transmitted, 3 received, 0% packet loss, time 0ms > -]) > - > dnl Ipv4 fragmentation connectivity check. > NS_CHECK_EXEC([at_ns0], [ping -s 1600 -q -c 3 -i 0.3 -w 2 10.1.1.2 | > FORMAT_PING], [0], [dnl > 3 packets transmitted, 3 received, 0% packet loss, time 0ms > @@ -1406,11 +1398,6 @@ > priority=100,in_port=2,ct_state=+trk+est-new,icmp,action=1 > > AT_CHECK([ovs-ofctl --bundle add-flows br0 flows.txt]) > > -dnl Basic connectivity check. > -NS_CHECK_EXEC([at_ns0], [ping -q -c 3 -i 0.3 -w 2 10.1.1.2 | FORMAT_PING], > [0], [dnl > -3 packets transmitted, 3 received, 0% packet loss, time 0ms > -]) > - > dnl Ipv4 fragmentation connectivity check. > NS_CHECK_EXEC([at_ns0], [ping -s 1600 -q -c 1 -i 0.3 -w 2 10.1.1.2 | > FORMAT_PING], [0], [dnl > 7 packets transmitted, 0 received, 100% packet loss, time 0ms > @@ -1441,11 +1428,6 @@ > priority=100,in_port=2,ct_state=+trk+est-new,icmp,action=1 > > AT_CHECK([ovs-ofctl --bundle add-flows br0 flows.txt]) > > -dnl Basic connectivity check. > -NS_CHECK_EXEC([at_ns0], [ping -q -c 3 -i 0.3 -w 2 10.2.2.2 | FORMAT_PING], > [0], [dnl > -3 packets transmitted, 3 received, 0% packet loss, time 0ms > -]) > - > dnl Ipv4 fragmentation connectivity check. > NS_CHECK_EXEC([at_ns0], [ping -s 1600 -q -c 3 -i 0.3 -w 2 10.2.2.2 | > FORMAT_PING], [0], [dnl > 3 packets transmitted, 3 received, 0% packet loss, time 0ms > @@ -1485,11 +1467,6 @@ dnl waiting, we get occasional failures due to the > following error: > dnl "connect: Cannot assign requested address" > OVS_WAIT_UNTIL([ip netns exec at_ns0 ping6 -c 1 fc00::2]) > > -dnl Basic connectivity check. > -NS_CHECK_EXEC([at_ns0], [ping6 -q -c 3 -i 0.3 -w 2 fc00::2 | FORMAT_PING], > [0], [dnl > -3 packets transmitted, 3 received, 0% packet loss, time 0ms > -]) > - > dnl Ipv6 fragmentation connectivity check. > NS_CHECK_EXEC([at_ns0], [ping6 -s 1600 -q -c 3 -i 0.3 -w 2 fc00::2 | > FORMAT_PING], [0], [dnl > 3 packets transmitted, 3 received, 0% packet loss, time 0ms > @@ -1533,11 +1510,6 @@ dnl waiting, we get occasional failures due to the > following error: > dnl "connect: Cannot assign requested address" > OVS_WAIT_UNTIL([ip netns exec at_ns0 ping6 -c 1 fc00::2]) > > -dnl Basic connectivity check. > -NS_CHECK_EXEC([at_ns0], [ping6 -q -c 3 -i 0.3 -w 2 fc00::2 | FORMAT_PING], > [0], [dnl > -3 packets transmitted, 3 received, 0% packet loss, time 0ms > -]) > - > dnl Send an IPv6 fragment. Some time later, it should expire. > NS_CHECK_EXEC([at_ns0], [ping6 -s 1600 -q -c 1 -i 0.3 -w 2 fc00::2 | > FORMAT_PING], [0], [dnl > 7 packets transmitted, 0 received, 100% packet loss, time 0ms > @@ -1577,11 +1549,6 @@ dnl waiting, we get occasional failures due to the > following error: > dnl "connect: Cannot assign requested address" > OVS_WAIT_UNTIL([ip netns exec at_ns0 ping6 -c 1 fc00::2]) > > -dnl Basic connectivity check. > -NS_CHECK_EXEC([at_ns0], [ping6 -q -c 3 -i 0.3 -w 2 fc00:1::4 | FORMAT_PING], > [0], [dnl > -3 packets transmitted, 3 received, 0% packet loss, time 0ms > -]) > - > dnl Ipv4 fragmentation connectivity check. > NS_CHECK_EXEC([at_ns0], [ping6 -s 1600 -q -c 3 -i 0.3 -w 2 fc00:1::4 | > FORMAT_PING], [0], [dnl > 3 packets transmitted, 3 received, 0% packet loss, time 0ms > -- > 2.8.2 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
