On Thu, Jul 7, 2016 at 1:52 PM, Flaviof <fla...@flaviof.com> wrote: > On Thu, Jul 7, 2016 at 2:37 PM, Ryan Moats <rmo...@us.ibm.com> wrote: > > > Currently, when address set value changes, ovn controller > > doesn't remove the old entry from the tracking hash, it > > just adds the new one, leading to multiple entries for the > > same symbol. > > > > Fix this behavior and add a smoke test to avoid a regression > > in the future. > > > > Signed-off-by: Ryan Moats <rmo...@us.ibm.com> > > > > > Acked-by: Flavio Fernandes <fla...@flaviof.com> >
Thanks! I verified that the test fails before the patch, and passes after. I pushed this to master with the addition of a comment helping explain the purpose of the test case: diff --git a/tests/ovn.at b/tests/ovn.at index 344d07f..892d068 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -3366,6 +3366,11 @@ ovn-nbctl destroy Address_Set $row sleep 1 +# A bug previously existed in the address set support code +# that caused ovn-controller to crash after an address set +# was updated and then removed. This test case ensures +# that ovn-controller is at least still running after +# creating, updating, and deleting an address set. AT_CHECK([ovs-appctl -t ovn-controller version], [0], [ignore]) OVN_CLEANUP([hv1]) _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev