> On Jul 12, 2016, at 11:57 PM, Daniele Di Proietto <diproiet...@ovn.org> wrote: > > Acked-by: Daniele Di Proietto <diproiet...@vmware.com> > > I see that there are a bunch of similar problems in the tree. > > Should we fix those? I started working on a series, though a lot of creative > naming is required > > Should we enable -Wshadow in configure.ac?
Yeah, this effort started off that way, but, as you noticed, it becomes a bigger project. I didn't want to take that on today, so I just wanted to quickly fix the ones that actually looked like problems. I think it would be great if we could get OVS to build with -Wshadow. If no one beats me to it, I may make another stab at it when I get more time, but clearly no one should be blocking on me these days. :-( Thanks for the quick reviews. I'll push the series in a minute. --Justin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
