> On Jul 2, 2016, at 10:25 AM, Ben Pfaff <b...@ovn.org> wrote: > > On Fri, Jun 24, 2016 at 12:39:54PM -0400, Hui Kang wrote: >> These variables indicate ports in nb switches or routers. >> >> Signed-off-by: Hui Kang <ka...@us.ibm.com> > > Justin, do you want to review this? You like naming.
I'll take that as the compliment that I'm sure it was intended. O.o I think this is a good change because "nbr" (and "nbs") is used as the variable name for both a router (and switch) and its ports, which could be confusing when reading the code. I'd make it clearer in the commit message that that's its intent. In the title, I'd label is something like "Rename nbs/nbr port names to nbsp/nbrp." --Justin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
