Hi Alin, I know this can be confusing but after a second thought I think mine is correct. Your suggestion is equivalent to (abbreviated): !(port == geneve && port == vxlan) which is always TRUE because port can not be both type at the same time.
Thanks, Yin On Thu, Jul 21, 2016 at 7:00 AM, Alin Serdean < aserd...@cloudbasesolutions.com> wrote: > > > > -----Mesaj original----- > > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Alin Serdean > > Trimis: Thursday, July 21, 2016 4:30 PM > > Către: Yin Lin <li...@vmware.com>; dev@openvswitch.org > > Subiect: Re: [ovs-dev] [PATCH] datapath-windows: Fix various Geneve bugs > > > > Hi Yin, > > > > Thanks for the patch one. Just one small question from me inlined. > > > > > -----Mesaj original----- > > > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Yin Lin > > > Trimis: Thursday, July 14, 2016 6:21 AM > > > Către: dev@openvswitch.org > > > Cc: Yin Lin <li...@vmware.com> > > > Subiect: [ovs-dev] [PATCH] datapath-windows: Fix various Geneve bugs > > > > > > Signed-off-by: Yin Lin <li...@vmware.com> > > > --- > > > datapath-windows/ovsext/Flow.c | 2 +- > > > datapath-windows/ovsext/Vport.c | 3 ++- datapath- > > > windows/ovsext/Vport.h | 5 +++++ > > > 3 files changed, 8 insertions(+), 2 deletions(-) > > > - if (vport->ovsType != OVS_VPORT_TYPE_VXLAN) { > > > + if (vport->ovsType != OVS_VPORT_TYPE_GENEVE && > > [Alin Gabriel Serdean: ] Shouldn't it be a || ("vport->ovsType != > > OVS_VPORT_TYPE_GENEVE ||") ? > [Alin Gabriel Serdean: ] Small edit "vport->ovsType != > OVS_VPORT_TYPE_GENEVE ||" > > > + vport->ovsType != OVS_VPORT_TYPE_VXLAN) { > > > continue; > > > } > > > break; > > > diff --git a/datapath-windows/ovsext/Vport.h b/datapath- > > > windows/ovsext/Vport.h index f0a9acd..1f4968e 100644 > > > --- a/datapath-windows/ovsext/Vport.h > > > +++ b/datapath-windows/ovsext/Vport.h > > > @@ -21,6 +21,7 @@ > > > > _______________________________________________ > > dev mailing list > > dev@openvswitch.org > > http://openvswitch.org/mailman/listinfo/dev > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
