On Tue, Jul 26, 2016 at 9:23 AM, Jesse Gross <je...@kernel.org> wrote: > On Mon, Jul 25, 2016 at 5:49 PM, Pravin B Shelar <pshe...@ovn.org> wrote: >> diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c >> index 8368c6a..de9c8e1 100644 >> --- a/datapath/linux/compat/gso.c >> +++ b/datapath/linux/compat/gso.c >> @@ -286,17 +282,15 @@ int rpl_ip_local_out(struct net *net, struct sock *sk, >> struct sk_buff *skb) >> err = skb_checksum_help(skb); >> if (unlikely(err)) >> return 0; >> + return output_ip(skb); > > I guess this isn't strictly necessary - the loop will set the IP ID to > the existing value, which isn't necessary but should be harmless. > Maybe a nicer way would be to move the loop to the GSO block and then > just have an output_ip() call at the end. Either way, it would be good > to be consistent with the IPv6 code.
I guess that is also fine. I will make the change. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
