> On Jul 29, 2016, at 1:07 PM, Ben Pfaff <[email protected]> wrote: > > On Thu, Jul 28, 2016 at 05:56:01PM -0700, Jarno Rajahalme wrote: >> This changes ofproto providers modify_group() to never fail. >> >> Separating major refactoring to a separate patch should make following >> patches easier to review. >> >> Signed-off-by: Jarno Rajahalme <[email protected]> > > Needs the "sparse" warning fix from RULE_COLLECTION(S)_FOR_EACH for > GROUP_COLLECTION(S)_FOR_EACH as well. >
Done. > I recommend being really careful about self-review for > modify_group_start(). That code has been super-buggy in the past, for > the cases of inserting and deleting buckets. > Luckily I did not need to touch those cases now. > Acked-by: Ben Pfaff <[email protected]> Thanks! Jarno _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
