On Sun, Jul 31, 2016 at 10:28:20PM -0500, Justin Pettit wrote: > > > On Jul 29, 2016, at 11:49 AM, Ben Pfaff <b...@ovn.org> wrote: > > > > On Thu, Jul 28, 2016 at 11:26:12PM -0700, Justin Pettit wrote: > >> Rename "compose_nd" and "compose_na" to "compose_nd_ns" and > >> "compose_nd_na", respecively, to be clearer about their functionality. > >> This will also make it more consistent when we add Neighbor Discover > >> Router Solicitation/Advertisement compose functions. > >> > >> Also change the source and destination IPv6 addresses to take > >> "struct in6_addr" arguments, which are more common in the code base. > >> > >> Signed-off-by: Justin Pettit <jpet...@ovn.org> > >> > >> --- > >> v1->v2: Renamed functions to be consistent when adding more ND messages. > >> Fix alignment issues introduced with taking "struct in6_addr". > > > > I don't think that the ALIGNED_CASTs in compose_nd_ns() and > > compose_nd_na() are necessarily safe, on a system that lacks s6_addr32. > > Thanks for catching that. From a library perspective, I think we > should change the arguments to packet_set_nd() to accept an in6_addr, > but that's a more invasive change than I want to make right now. I'll > put it on my todo list. How about the incremental below for now, > though?
Looks good to me. Acked-by: Ben Pfaff <b...@ovn.org> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
