On Wed, Aug 3, 2016 at 7:56 PM, Russell Bryant <russ...@ovn.org> wrote: > > > On Wed, Aug 3, 2016 at 7:01 AM, Zong Kai LI <zealo...@gmail.com> wrote: >> >> This patch aims to extend Address_Set to Macros_Set, make it more common >> to >> accept variable set, not only address. And by that, we can skinny down >> ACLs, >> if we use Macros_Set to defines port sets for ACL to use, since lots of >> ACL >> entries are similar but only "inport" and "outport" fields are different. > > > I think the idea makes sense. > > I wonder if just "Set" would be an appropriate name. One catch is that it > may be too late to get into OVS 2.6. If so, then we have to take into > account backwards compatibility. We won't be able to just rename the table. > One option would be to at least rename the table now (before 2.6) to reflect > a more broad purpose, and leave the support for other types of entries to > later patches. > > Are you looking for any other specific feedback? > > -- > Russell Bryant
Hi, Russell. I noticed "Macros_Set" is redundant to "Macros", but I'm not so sure, so I left it in this version. Most code in this patch is "rename", fewer is to extend to support string type members, like port name. So I think it's ok to do both rename and support string members. And left any other support and enhance in follow patches. Any other special feedback, yes, I hope that. To make a simple beginning, I didn't do any changing in ovn-northd, but I think it's possible to make ovn-northd to use it on some lflows. Not sure whether it's worth to do that, or will it make ovn-northd code complex. So I list this in TODO. Thanks, Zongkai, LI _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev