On 4 August 2016 at 18:40, Daniele Di Proietto <diproiet...@vmware.com> wrote:
> If the ethtool command is not available on the system we should fail,
> since the userspace testsuite cannot work properly without disabling
> offloads.
>
> Also, add ethtool to the list of installed packages on Vagrantfile.
>
> Fixes: ddcf96d2dcc1 ("system-tests: Disable offloads in userspace tests.")
> Reported-by: Joe Stringer <j...@ovn.org>
> Signed-off-by: Daniele Di Proietto <diproiet...@vmware.com>Thanks, this should make it more obvious when offloads are causing failures. The commit message doesn't really explain why the vagrantfile change is in the same commit; a simple mention that it's being added here 'to ensure that offloads don't cause test failures in the vagrant VM when the kernel is updated' would make it more clear why these two changes are in the same commit. Acked-by: Joe Stringer <j...@ovn.org> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
