On Fri, Aug 12, 2016 at 09:35:07AM -0500, Ryan Moats wrote:
> Ensure that rows created for deleted port binding and
> multicast group rows are cleared when doing full processing.
>
> Signed-off-by: Ryan Moats <rmo...@us.ibm.com>
> ---
> v1->v2:
> - replace use of ssets for storing UUIDs as strings with hmaps for
> storing the UUID structs themselves
> - include an optimization suggested by Ben when reviewing v1
I'm pretty sure that this leaks all of the nodes removed from the hmap
by hmap_clear(new) in rationalize_hmap_and_delete_flows().
One style fix:
diff --git a/ovn/controller/physical.c b/ovn/controller/physical.c
index a27c1ac..cd1703b 100644
--- a/ovn/controller/physical.c
+++ b/ovn/controller/physical.c
@@ -647,7 +647,8 @@ consider_mc_group(enum mf_field_id mff_ovn_geneve,
}
static bool
-find_uuid_in_hmap(struct hmap *hmap_p, struct uuid *uuid) {
+find_uuid_in_hmap(struct hmap *hmap_p, struct uuid *uuid)
+{
struct uuid_hash_node *candidate;
HMAP_FOR_EACH_WITH_HASH (candidate, node, uuid_hash(uuid), hmap_p) {
if (uuid_equals(uuid, &candidate->uuid)) {
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
