On Thu, Sep 01, 2016 at 01:18:55PM -0700, Ben Pfaff wrote:
> On Thu, Sep 01, 2016 at 01:10:37PM -0700, Jarno Rajahalme wrote:
> > Avoid using nested zero-sized arrays to allow compilation with MSVC.
> > Also, make sure the immediate data is accessed only if it exists, and
> > that the size is always calculated from struct learn_spec field
> > 'n_bits'.
> > 
> > Reported-by: Alin Serdean <aserd...@cloudbasesolutions.com>
> > Signed-off-by: Jarno Rajahalme <ja...@ovn.org>
> 
> It looks good to me but the title could be more specific.  "learn: Avoid
> nested zero-sized arrays to fix build with MSVC." or some such.
> 
> Acked-by: Ben Pfaff <b...@ovn.org>

Also this is a good place for a Fixes header, e.g.
Fixes: dfe191d5faa6 ("ofp-actions: Waste less memory in learn actions.")
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to