On Fri, Sep 2, 2016 at 1:55 PM, Ben Pfaff <b...@ovn.org> wrote:

> On Wed, Aug 31, 2016 at 07:32:41PM -0700, Andy Zhou wrote:
> > Added the '--no-sync' option base on feedbacks of current
> > implementation.
> >
> > Added appctl command "ovsdb-server/sync-status" based on feedbacks
> > of current implementation.
> >
> > Added the RPL_S_INIT state in the state machine. This state is
> > not strictly necessary for the replication state machine, but is
> > introduced to make sure the state is update immediately when
> > the state machine is reset, via replication_init(). Without it
> > ovsdb/sync-status may display "replicating" or crash, if the command
> > is issued between after replication_init() is called, but before
> > the state variable is updated from replication_run().
> >
> > Added a test to simulate the integration of HA manager with OVSDB
> > server using replication.
> >
> > Other documentation and API improvements.
> >
> > Tested-by: Numan Siddique <nusid...@redhat.com>
> > Signed-off-by: Andy Zhou <az...@ovn.org>
>
> Thanks for working on this.
>
> Until I read the documentation fairly carefully, I was a bit mystified
> by --no-sync.  I don't like negative forms very much to start out with,
> but it also wasn't clear why I'd want to specify where to sync from but
> not to sync.  Then I figured out that it's really just saying to start
> in active mode.
>
> So I'd suggest renaming --no-sync to --active.
>

Thanks Ben for the review. I have folded in your suggestions and pushed to
master.  Also back ported the whole series to branch 2.6.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to