> On Sep 19, 2016, at 10:40 PM, Guru Shetty <g...@ovn.org> wrote: > > On 19 September 2016 at 05:16, nickcooper-zhangtonghao > <nickcooper-zhangtong...@opencloud.tech > <mailto:nickcooper-zhangtong...@opencloud.tech>> wrote: > This patch provides the command line to create a load balancer. > You can create a load balancer independently and add it to multiple > switches or routers. A single load balancer can have multiple vips. > Add a name column for the load balancer. With --add-duplicate, > the command really creates a new load balancer with a duplicate name. > This name has no special meaning or purpose other than to provide > convenience for human interaction with the ovn-nb database. > This patch also provides the unit tests and the documentation. > > Signed-off-by: nickcooper-zhangtonghao > <nickcooper-zhangtong...@opencloud.tech> > > I get the following compilation error: > > ovn/utilities/ovn-nbctl.c: In function ‘nbctl_lb_list_router’: > ovn/utilities/ovn-nbctl.c:1493:13: error: format not a string literal and no > format arguments [-Werror=format-security] > smap_add_format(lbs, ds_cstr(&key), ds_cstr(&val)); > ^ > ovn/utilities/ovn-nbctl.c: In function ‘nbctl_lb_list_switch’: > ovn/utilities/ovn-nbctl.c:1540:13: error: format not a string literal and no > format arguments [-Werror=format-security] > smap_add_format(lbs, ds_cstr(&key), ds_cstr(&val)); > ^ > ovn/utilities/ovn-nbctl.c: In function ‘nbctl_lb_list_all’: > ovn/utilities/ovn-nbctl.c:1584:13: error: format not a string literal and no > format arguments [-Werror=format-security] > smap_add_format(lbs, ds_cstr(&key), ds_cstr(&val)); > ^ > cc1: all warnings being treated as errors > make[2]: *** [ovn/utilities/ovn-nbctl.o] Error 1 > make[2]: *** Waiting for unfinished jobs.... > make[2]: Leaving directory `/root/git/openvswitch' > make[1]: *** [all-recursive] Error 1 > make[1]: Leaving directory `/root/git/openvswitch' > make: *** [all] Error 2 > > Can you please add to the unit test the scenario where we have multiple vips > in a single load balancer and lb-list it.. Also add the case wherein the vip > is just an IP address. Also, please update the version number in schema to > 5.3.4 (the rationale is explained in 'man ovs-vswitchd.conf.db'. Search for > 'db_version'.)
I do not get the compilation error above. I submitted the v7 patch which updates the test case. Thanks for your review. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
