> On Sep 23, 2016, at 11:12 AM, Guru Shetty <g...@ovn.org> wrote:
> 
> 
> 
> On 23 September 2016 at 11:01, Justin Pettit <jpet...@ovn.org> wrote:
> 
> > On Sep 23, 2016, at 10:19 AM, Guru Shetty <g...@ovn.org> wrote:
> >
> >
> >
> > On 23 September 2016 at 01:53, Justin Pettit <jpet...@ovn.org> wrote:
> > If ovn-controller is restarted, it may choose different conntrack zones
> > than had been previously used, which could cause the wrong conntrack
> > entries to be associated with a logical port.  This commit stores in the
> > integration bridge's OVS "Bridge" table the mapping to the conntrack zone.
> >
> > Signed-off-by: Justin Pettit <jpet...@ovn.org>
> > ---
> >  ovn/controller/ovn-controller.8.xml |  14 ++++
> >  ovn/controller/ovn-controller.c     | 136 
> > ++++++++++++++++++++++++++++++++++--
> >  2 files changed, 146 insertions(+), 4 deletions(-)
> >
> > diff --git a/ovn/controller/ovn-controller.8.xml 
> > b/ovn/controller/ovn-controller.8.xml
> > index 559031f..0484263 100644
> > --- a/ovn/controller/ovn-controller.8.xml
> > +++ b/ovn/controller/ovn-controller.8.xml
> > @@ -200,6 +200,20 @@
> >        </dd>
> >
> >        <dt>
> > +        <code>external_ids:ct-zone-*</code> in the <code>Bridge</code> 
> > table
> > +      </dt>
> > +      <dd>
> > +        Logical ports and gateway routers are assigned a connection
> > +        tracking zone by <code>ovn-controller</code> for stateful
> > +        services.  To keep state across restarts of
> > +        <code>ovn-controller</code>, these keys are stored in the
> > +        integration bridge's Bridge table.  The name contains a prefix
> > +        of <code>ct-zone-</code> followed by the name of the logical
> > +        port.  The value for this key identifies the zone used for this
> > +        port.
> > I suppose the above is not really true as we also have gateway routers.
> 
> I'm not sure I understand.  Are you saying that my use of port doesn't cover 
> the gateway routers or something else?  Do you have a suggested change of 
> text or are you raising a more fundamental concern?
> 
> No fundamental concerns. The text would be more right with the following 
> substitution.
> 
> s/ followed by the name of the logical port/ followed by a key that 
> identifies the
>  logical port or the gateway router/

I changed the sentence to the following, since I was worried that "key" was 
being used in different contexts in that paragraph:

        The name contains a prefix
        of <code>ct-zone-</code> followed by the name of the logical
        port or the gateway router.

Are you good with it?

--Justin


_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to