2016-10-19 13:42 GMT-07:00 Jarno Rajahalme <[email protected]>: > > > On Oct 19, 2016, at 10:01 AM, Joe Stringer <[email protected]> wrote: > > > > On 14 October 2016 at 07:37, Bhanuprakash Bodireddy > > <[email protected]> wrote: > >> Aligning the 'keys' array seems to have positive performance impact. > >> > >> Signed-off-by: Bhanuprakash Bodireddy <[email protected] > > > >> Co-authored-by: Antonio Fischetti <[email protected]> > >> Signed-off-by: Antonio Fischetti <[email protected]> > >> Acked-by: Daniele Di Proietto <[email protected]> > > > > It looks like the Windows build was broken after this change: > > https://ci.appveyor.com/project/blp/ovs/build/1.0.2391 > > > > Will one of you take a look? > > The example in include/openvswitch/compiler.c has the OVS_ALIGNED_VAR() > before the declaration, not after, so changing the modified line > accordingly might help. I’d not want to propose a patch before testing that > this fixes the Windows build, though, and I do not have access to a Windows > build system… >
I tried that on a Windows system and it appears to fix the issue. I'm sending a patch Sorry for the breakage and thanks for reporting this Joe! _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
