I thought we had set warnings to be treated as error. Appveyor didn¹t catch this one either. Thanks for fixing this.
Acked-by: Sairam Venugopal <vsai...@vmware.com> On 10/27/16, 12:20 PM, "Alin Serdean" <aserd...@cloudbasesolutions.com> wrote: >ofpbuf_const_initializer takes only two parameters see: > >https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openvswitc >h_ovs_blob_master_include_openvswitch_ofpbuf.h-23L96&d=CwIGaQ&c=Sqcl0Ez6M0 >X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=Dcruz40PROJ40ROzSpxyQSLw6fcrOWpJgEcEmN >R3JEQ&m=hW8JkDjtdjUkx6FWcuFVzuV1QybnJJUmFaqnKtac2xQ&s=2QeOkFwLYxAhyEcQGyKo >6GJ8Z8KgavEI1u1sVymnHag&e= > >the compiler only gives the following warning: > >lib/netdev-windows.c(229) : warning C4020: 'ofpbuf_const_initializer' : >too many actual parameters > >which in result will put junk data into "ofpbuf b". > >This patch fixes the initialization. > >Signed-off-by: Alin Gabriel Serdean <aserd...@cloudbasesolutions.com> >--- > lib/netdev-windows.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/lib/netdev-windows.c b/lib/netdev-windows.c >index 3218490..423a00b 100644 >--- a/lib/netdev-windows.c >+++ b/lib/netdev-windows.c >@@ -226,7 +226,7 @@ netdev_windows_netdev_from_ofpbuf(struct >netdev_windows_netdev_info *info, > > netdev_windows_info_init(info); > >- struct ofpbuf b = ofpbuf_const_initializer(&b, buf->data, buf->size); >+ struct ofpbuf b = ofpbuf_const_initializer(buf->data, buf->size); > struct nlmsghdr *nlmsg = ofpbuf_try_pull(&b, sizeof *nlmsg); > struct genlmsghdr *genl = ofpbuf_try_pull(&b, sizeof *genl); > struct ovs_header *ovs_header = ofpbuf_try_pull(&b, sizeof >*ovs_header); >-- >2.9.2.windows.1 >_______________________________________________ >dev mailing list >dev@openvswitch.org >https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailma >n_listinfo_dev&d=CwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=Dc >ruz40PROJ40ROzSpxyQSLw6fcrOWpJgEcEmNR3JEQ&m=hW8JkDjtdjUkx6FWcuFVzuV1QybnJJ >UmFaqnKtac2xQ&s=2ytbuFMxEgjkrn_32J0RWcRQUSDgjhkggbU5trvf20Q&e= _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
