On Thu, Jan 14, 2010 at 7:31 PM, David Ezzio <[email protected]> wrote: > Hi Gurkan, > > Comments inline. > > David > > Gurkan Erdogdu wrote: >> >> Hi David; >> >> Thanks for comments. >> >>>>> M2_REPO/xml-apis/xml-apis/1.0.b2/xml-apis-1.0.b2.jar -- not needed for >>>>> compilation >> >> webbeans-impl's pom.xml does not contain this. Where is the location of >> this dependency, which pom? > > I don't pretend to know how the eclipse:eclipse mojo works. The xml-apis > jar did show up in the imports of the generated projects. The only pom that > has it is the webbeans-tck/pom.xml.
the import is inherited b/c of dom4j ... > >> >>>>> Also, M2_REPO/javassist/javassist/3.8.0.GA/javassist-3.8.0.GA.jar -- >> >> used in one class that appears to be a test helper. If it is not used >> elsewhere, you might consider removing it. >> Look at org.apache.webbeans.proxy.JavassistProxyFactory class in >> webbeans-impl module, it uses javassist.jar that is defined in >> "trunk/pom.xml". This jar is required. > > Yes, I was a dummy to miss that! Thanks. > >> >>>>> For webbeans-resource: >> >> webbeans-resource depends on webbeans-impl module, so it transitively get >> your listed modules except xml-apis. I do not see xml-api jar. >> >> Thanks; >> >> --Gurkan >> >> >> ________________________________ >> From: David Ezzio <[email protected]> >> To: [email protected] >> Sent: Wed, January 13, 2010 5:47:49 PM >> Subject: Comments on dependencies >> >> All, >> >> At rev 898415, I set up Eclipse projects using the eclipse plugin. >> >> Systematically removing M2_REPO jars from the project's dependency list, I >> discovered the following: >> >> For webbeans-impl: >> >> M2_REPO/xml-apis/xml-apis/1.0.b2/xml-apis-1.0.b2.jar -- not needed for >> compilation >> >> Also, M2_REPO/javassist/javassist/3.8.0.GA/javassist-3.8.0.GA.jar -- used >> in one class that appears to be a test helper. If it is not used elsewhere, >> you might consider removing it. >> >> For webbeans-resource: >> >> M2_REPO/javassist/javassist/3.8.0.GA/javassist-3.8.0.GA.jar -- not needed >> for compilation >> >> M2_REPO/dom4j/dom4j/1.6.1/dom4j-1.6.1.jar -- not needed for compilation >> >> M2_REPO/net/sf/scannotation/scannotation/1.0.2/scannotation-1.0.2.jar -- >> not needed for compilation >> >> M2_REPO/xml-apis/xml-apis/1.0.b2/xml-apis-1.0.b2.jar -- not needed for >> compilation >> >> Any corrections welcomed. >> >> David >> >> >> >> ___________________________________________________________________ >> Yahoo! Türkiye açıldı! http://yahoo.com.tr >> İnternet üzerindeki en iyi içeriği Yahoo! Türkiye sizlere sunuyor! > -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
