Hi Mark;

You have committed some code over weekend related with serialization etc. I
have skimmed over  some changes. My observations are:

1* You treat all beans as passivation capable and saving info (Changinb
BeanManagerImpl)
    I think that this is wrong. You said said in commit comment :

This is needed since we also need to serialise proxies of NormalScoped
> Beans which are not passivating. Imagine an @ApplicationScoped userService
> gets injected into a @ViewScoped ListModel.
>
> But spec. does not allows this. If you have a passivating capable and it
contains not passivating capable dependency you have to throw exception.
(Section 6.6.4)

2* You set ApplicationScopedLiteral to ConversationBean
  This is not true, ConversationBean scope must be RequestScoped.

3* You add "isDependent" to OwbBean but you do not implement this in
AbstractInjectionTarget, ProducerFieldBean, EJBean etc.

Thanks;

--Gurkan

Reply via email to