To relativate this: I'm currently a bit frustrated and angry mainly about myself, because such things should never have slipped under my radar.
Part of our code is currently so complex that only the one who wrote it understands it, so we are really low with reviews atm. We should move on to stick more to design principals, and if a code like the current InterceptorHandler is so complex and cyclically refered by lots of classes, then we should listen to findbugs, pmd, ... and refactor that code. If we have a clearer design in this area, then the code should shrink down to ~50% and also will be much easier to read. LieGrue, strub --- Mark Struberg <[email protected]> schrieb am Di, 23.3.2010: > Von: Mark Struberg <[email protected]> > Betreff: please avoid putting into internal maps in external locations > An: [email protected] > Datum: Dienstag, 23. März, 2010 15:09 Uhr > Hi folks! > > Please, don't put somthing into a map by writing code like > > JavassistProxyFactory.getInterceptorProxyClasses().put(bean, > proxyClass); > > This is absolutely unmaintainable! > Maps should generally be considered immutable if they are > not defined inside the own dependency chain (member of own > class or protected member of superclass) > > txs, > strub > > __________________________________________________ > Do You Yahoo!? > Sie sind Spam leid? Yahoo! Mail verfügt über einen > herausragenden Schutz gegen Massenmails. > http://mail.yahoo.com > __________________________________________________ Do You Yahoo!? Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen Massenmails. http://mail.yahoo.com
