Re: Is this correct?

[Gurkan Erdogdu]

Hi David;


Yes correct. Checking injections for Event<Type> or Instance<Type>, for example

@Inject Event<LoggingEvent> myEvent;

@Inject Instance<MyBean> instance;

thanks;

--Gurkan


----- Original Message ----
From: David Jencks <david_jen...@yahoo.com>
To: dev@openwebbeans.apache.org
Sent: Tue, October 19, 2010 7:25:55 AM
Subject: Is this correct?

Is this code in InjectionResolver line 258 correct?  I would expect the 
isAssignableFrom tests to be outside the deparameterizing of the type.  



private boolean isInstanceOrEventInjection(Type type)
    {
        Class<?> clazz = null;
        boolean injectInstanceOrEventProvider = false;
        if (type instanceof ParameterizedType)
        {
            ParameterizedType pt = (ParameterizedType) type;            
            clazz = (Class<?>) pt.getRawType();
                        
            if(clazz.isAssignableFrom(Instance.class) || 
clazz.isAssignableFrom(Event.class))
            {
                injectInstanceOrEventProvider = true;
            }            
        }
        
        return injectInstanceOrEventProvider;
    }


thanks
david jencks