My opinion as a pretty much completely inactive contributor to OWB is that it
would be better to have the test classes follow the same style rules as the
main code, but I'm not prepared to help fix it.
thanks
david jencks
On Sep 15, 2012, at 11:09 AM, Thomas Andraschko wrote:
> I use the same rules as the maven plugin, you must just import the settings.
> The problem is that maven-checkstyle-plugin does not check the test-src but
> eclipse does (per default).
>
> So what do you think? should we fix this errors or should the developers
> exclude test classes?
>
> 2012/9/15 Joseph Bergmark <bergm...@apache.org>
>
>> I haven't used the checkstyle plugin for Eclipse, so afraid I can't
>> provide much advice here. Its too bad it doesn't appear to follow the
>> same rules as the maven plugin.
>>
>> Sincerely,
>>
>> Joe
>>
>> On Sat, Sep 15, 2012 at 1:15 PM, Thomas Andraschko <zoi...@gmail.com>
>> wrote:
>>> It's only in test-classes because the won't be checked by maven.
>>> For example -> AbstractUnitTest#addExtension
>>>
>>> 2012/9/15 Joseph Bergmark <bergm...@apache.org>
>>>
>>>> Which test classes are you getting check style errors in? When I
>>>> build on the command line I don't see any check style errors:
>>>>
>>>> [INFO] --- maven-checkstyle-plugin:2.7:check (verify-style) @
>>>> openwebbeans-web ---
>>>> [INFO]
>>>> [INFO]
>>>>
>>>>
>>>> [INFO] --- maven-checkstyle-plugin:2.7:check (verify-style) @
>>>> openwebbeans-impl ---
>>>> [INFO]
>>>> [INFO]
>>>>
>>>> etc..
>>>>
>>>> Sincerely,
>>>>
>>>> Joe
>>>>
>>>> On Sat, Sep 15, 2012 at 12:26 PM, Thomas Andraschko <zoi...@gmail.com>
>>>> wrote:
>>>>> Hi,
>>>>>
>>>>> we have many checkstyle errors (not warnings) in the test classes.
>>>>> Can i fix them or should i exclude (don't know if possible in Eclipse)
>>>> the
>>>>> test classes from checkstyle?
>>>>> The most errors are "{ should be on a new line" and naming errors of
>>>>> constants and variables.
>>>>>
>>>>> Also i have many eclipse errors that @PostConstruct, @PreDestory,
>>>>> @WebServiceRef etc are not accessible.
>>>>> Can we add this APIs with provided scope or is there any better
>> solution?
>>>>>
>>>>> Regards,
>>>>> Thomas
>>>>
>>
