Sure, the last synchro is fine but using a "copyonwrite" set (array iterator) would be more efficient and thread safe...hashset are not and the copy done in get"set" method can still fail....
So the bug is still here IMO Le 12 mai 2013 10:56, "Mark Struberg" <strub...@yahoo.de> a écrit : > Romain, the previous code had a synchronized block for writes but none for > reads. This was broken. > The new solution is not perfect but definitely better. > > LieGrue, > strub > > > > > ----- Original Message ----- > > From: Romain Manni-Bucau <rmannibu...@gmail.com> > > To: Mark Struberg <strub...@yahoo.de>; dev@openwebbeans.apache.org > > Cc: > > Sent: Sunday, 12 May 2013, 9:40 > > Subject: Re: [VOTE] take2 - Release OWB-1.2.0 > > > > I said yesterday which solution id like to see, i have no computer before > > tonight so i didnt impl it and wanted some discussion before choosing... > > > > It is a reason for a -1 since it is a place id like to see stable code > (it > > is a place well have a bunch of issue because of old extensions). > > Le 12 mai 2013 09:33, "Mark Struberg" <strub...@yahoo.de> a > > écrit : > > > >> +1 > >> > >> LieGrue, > >> strub > >> > >> > >> > >> ----- Original Message ----- > >> > From: Mark Struberg <strub...@yahoo.de> > >> > To: openwebbeans-dev <dev@openwebbeans.apache.org>; > > openwebbeans-user < > >> u...@openwebbeans.apache.org> > >> > Cc: > >> > Sent: Sunday, 12 May 2013, 1:39 > >> > Subject: [VOTE] take2 - Release OWB-1.2.0 > >> > > >> > I'd like to call a 2nd take to VOTE on releasing Apache > >> OpenWebBeans-1.2.0 . > >> > > >> > This is the first release of the OpenWebBeans-1.2.x branch. > >> > This release changed many internal mechanics but still targets > >> > the CDI-1.0 specification. > >> > > >> > Please note that the source binary contains a few non-enabled modules > >> like > >> > webbeans-cdi11. They do pass RAT though. > >> > > >> > > >> > The ReleaseNotes are available online: > >> > > >> > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310844&version=12315461 > >> > > >> > Maven staging repo: > >> > > >> > > > https://repository.apache.org/content/repositories/orgapacheopenwebbeans-004/ > >> > > >> > SVN source tag: > >> > > https://svn.apache.org/repos/asf/openwebbeans/tags/openwebbeans-1.2.0/ > >> > > >> > Source Release: > >> > > >> > > > https://repository.apache.org/content/repositories/orgapacheopenwebbeans-004/org/apache/openwebbeans/openwebbeans/1.2.0/openwebbeans-1.2.0-source-release.zip > >> > > >> > Binary release: > >> > > >> > > > https://repository.apache.org/content/repositories/orgapacheopenwebbeans-004/org/apache/openwebbeans/openwebbeans-distribution/1.2.0/openwebbeans-distribution-1.2.0-binary.zip > >> > > >> > PGP release key 2FDB81B1 > >> http://svn.apache.org/repos/asf/openwebbeans/trunk/KEYS > >> > > >> > The VOTE will be open for 72 hours. > >> > [ ] +1 approve > >> > [ ] +0 no opinion > >> > [ ] -1 veto (and reason why) > >> > > >> > LieGrue, > >> > strub > >> > > >> > > >
