[
https://issues.apache.org/jira/browse/OWB-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13755466#comment-13755466
]
Arjan Tijms commented on OWB-893:
---------------------------------
To make matters even more complicated, CanDI (Resin 4.0.36) does not allow
generics in producer methods at all. Period. It gave me the following exception:
{noformat}
classpath:META-INF/caucho/app-default.xml:55:
javax.enterprise.inject.InjectionException:
'public org.omnifaces.cdi.param.ParamValue
org.omnifaces.cdi.param.RequestParameterProducer.produce(javax.enterprise.inject.spi.InjectionPoint)'
is an invalid @Produces method because it returns a generic type class
org.omnifaces.cdi.param.ParamValue<produce_T_0>
{noformat}
Given the spec and above referenced CDI issue I don't think this is quite
right, but it does make things really difficult at this point.
> OpenWebBeans 1.2.1 fails when injecting generic value holder
> ------------------------------------------------------------
>
> Key: OWB-893
> URL: https://issues.apache.org/jira/browse/OWB-893
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Injection and Lookup
> Affects Versions: 1.2.1
> Reporter: Arjan Tijms
>
> In OmniFaces we're using a producer method with the following signature:
> {code}
> @Produces
> @Param
> public <V> ParamValue<V> produce(InjectionPoint injectionPoint)
> {code}
> Injection then takes place into a bean as follows:
> {code}
> @Inject @Param
> private ParamValue<String> text1;
> {code}
> {{@Param}} is a qualifier with only non-binding attributes.
> See
> [RequestParameterProducer|https://code.google.com/p/omnifaces/source/browse/src/org/omnifaces/cdi/param/RequestParameterProducer.java]
> and
> [Param|https://code.google.com/p/omnifaces/source/browse/src/org/omnifaces/cdi/Param.java]
> This works in all versions of Weld that we tested on and in OpenWebBeans
> 1.1.8 (TomEE 1.5.2.). Unfortunately it does not work with OpenWebBeans
> 1.2.1-SNAPSHOT (TomEE 1.6.0-SNAPSHOT).
> The problem seems to be that 1.2.1 has added an additional check in
> {{org.apache.webbeans.util.GenericsUtil.satisfiesDependency}} that wasn't
> there before:
> {code}
> return ClassUtil.isSame(injectionPointRawType, beanRawType)?
> isAssignableFrom(injectionPointType, beanType): false;
> {code}
> The problem is with {{isAssignableFrom}}, because the producer is always seen
> as producing a {{ParamValue<Object}}. The actual values at the point of
> evaluation with the above given injection example where:
> {noformat}
> injectionPoint = ParamValue<class java.lang.String>
> beanType = ParamValue<class java.lang.Object>
> {noformat}
> Those are not directly assignable so the injection fails.
> Is OmniFaces doing something wrong here, is this check to strict, or should
> the producer type not be seen as {{ParamValue<Object>}}?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
