[ 
https://issues.apache.org/jira/browse/OWB-898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13764555#comment-13764555
 ] 

Mark Struberg commented on OWB-898:
-----------------------------------

I agree that this has nothing to do with ASM nor the way we use it, but that we 
take the wrong route in whether to generate a delegater method for it at all.

We have to define clearly what the isOverridden() method should return. Imo it 
just reflects the fact that a method overrides another one from a parent class. 
And for example a private or a static method can never be overridden. This is 
important for e.g. having 2 private @Observes methods. Even if they have the 
same name and parameter set in a parent and a subclass, both methods must be 
taken as observer methods. Wheras making them both public will really 
'override' the method from the parent class, thus the parent class observer 
method will not get invoked.
                
> ClassFormatError in ASM engine
> ------------------------------
>
>                 Key: OWB-898
>                 URL: https://issues.apache.org/jira/browse/OWB-898
>             Project: OpenWebBeans
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.2.0, 1.2.1
>            Reporter: Tobias Stoeckmann
>              Labels: ASM, ClassFormatError, bug
>         Attachments: cdi-blow.zip
>
>
> It is possible for OpenWebBeans to throw a ClassFormatError while 
> constructing an instance of a class that "overrides" a package private method 
> of a super class with an own package private method. Technically, the methods 
> are not overriden, which leads to two methods with the same signature -- 
> therefore the FormatError.
> de.cewecolor.cdi.blow.sub.SuperClass#setValue(String)
> de.cewecolor.cdi.blow.SubClass#setValue(String) extends SuperClass
> BeanManager#getReference(SubClass.class) will throw an Error.
> Please see the attached example project, it's a very small example triggering 
> the issue (standalone container).
> I assume that this problem is related to the switch to ASM. For one, 
> OpenWebBeans 1.1.8 works fine and it can be seen here too: 
> http://issues.gradle.org//browse/GRADLE-2695
> Tested also with 1.2.1-SNAPSHOT which uses ASM 4, still the same issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to