I didn't look at the context, but your commit comment suggests that perhaps the previous throw should also be changed to DeploymentException? If not a comment why the DefinitionException is correct might be appropriate.
sorry I'm too lazy to look into this further myself…. thanks david jencks On Sep 5, 2014, at 12:25 PM, strub...@apache.org wrote: > Author: struberg > Date: Fri Sep 5 19:25:33 2014 > New Revision: 1622766 > > URL: http://svn.apache.org/r1622766 > Log: > DefinitionExceptions during startup need to be treated as DeploymentException > it seems > > at least according to the TCK. > > Modified: > > openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/config/BeansDeployer.java > > Modified: > openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/config/BeansDeployer.java > URL: > http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/config/BeansDeployer.java?rev=1622766&r1=1622765&r2=1622766&view=diff > ============================================================================== > --- > openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/config/BeansDeployer.java > (original) > +++ > openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/config/BeansDeployer.java > Fri Sep 5 19:25:33 2014 > @@ -278,6 +278,10 @@ public class BeansDeployer > { > throw new DefinitionException(e); > } > + catch (DefinitionException de) > + { > + throw new DeploymentException(de); > + } > catch (Exception e) > { > throw ExceptionUtil.throwAsRuntimeException(e); > >
