[
https://issues.apache.org/jira/browse/OWB-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867606#comment-16867606
]
Stephen Connolly commented on OWB-1290:
---------------------------------------
Well I have some good news...
I have a reproducer in tomcat also!
{code:java}
SEVERE: Servlet.service() for servlet [TestServlet] in context with path
[/owbtomcat7it] threw exception
javax.enterprise.inject.CreationException: java.lang.ClassNotFoundException:
org.apache.webbeans.proxy.OwbNormalScopeProxy
at
org.apache.webbeans.component.AbstractOwbBean.create(AbstractOwbBean.java:141)
at
org.apache.webbeans.context.DependentContext.getInstance(DependentContext.java:68)
at org.apache.webbeans.context.AbstractContext.get(AbstractContext.java:125)
at
org.apache.webbeans.container.BeanManagerImpl.getReference(BeanManagerImpl.java:813)
at
org.apache.webbeans.inject.instance.InstanceImpl.create(InstanceImpl.java:306)
at
org.apache.webbeans.inject.instance.InstanceImpl.get(InstanceImpl.java:135)
at
org.apache.webbeans.web.tomcat7.test.TestServlet.service(TestServlet.java:56)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
at
org.apache.webbeans.web.tomcat7.TomcatSecurityFilter.doFilter(TomcatSecurityFilter.java:67)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:218)
at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:122)
at
org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:505)
at
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:169)
at
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:103)
at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:958)
at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:116)
at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:452)
at
org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1087)
at
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:637)
at
org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:316)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at
org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.ClassNotFoundException:
org.apache.webbeans.proxy.OwbNormalScopeProxy
at
org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:50)
at
org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass(ClassRealm.java:271)
at
org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:247)
at
org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:239)
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
at java.lang.ClassLoader.defineClass(ClassLoader.java:642)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.apache.webbeans.proxy.Unsafe.defineAndLoadClass(Unsafe.java:121)
at
org.apache.webbeans.proxy.AbstractProxyFactory.createProxyClass(AbstractProxyFactory.java:280)
at
org.apache.webbeans.proxy.AbstractProxyFactory.createProxyClass(AbstractProxyFactory.java:250)
at
org.apache.webbeans.proxy.NormalScopeProxyFactory.createProxyClass(NormalScopeProxyFactory.java:271)
at
org.apache.webbeans.portable.ProviderBasedProducer.produce(ProviderBasedProducer.java:61)
at
org.apache.webbeans.portable.AbstractProducer.produce(AbstractProducer.java:134)
at
org.apache.webbeans.component.AbstractOwbBean.create(AbstractOwbBean.java:122)
... 26 more
{code}
Now going to test your fix
> java.lang.ClassNotFoundException:
> org.apache.webbeans.proxy.OwbNormalScopeProxy if request scope bean has a
> classloader missing the proxy marker
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OWB-1290
> URL: https://issues.apache.org/jira/browse/OWB-1290
> Project: OpenWebBeans
> Issue Type: Improvement
> Components: Injection and Lookup
> Reporter: Stephen Connolly
> Priority: Major
>
> In some servlet containers (I'm looking at you
> [jetty|https://www.eclipse.org/jetty/]) the `HttpServletRequest` class is
> loaded from a classloader that is a common parent of both the webapp and the
> server.
> If you are integrating OWB by including the OWB JAR files in the webapp's
> .war file (as distinct from a server-side integration) then, naturally
> enough, the classloader of `HttpServletRequest` will not have the
> `OwbNormalScopeProxy` class... because it shouldn't
> When you then try to inject a `HttpServletRequest`, we get to
> [https://github.com/apache/openwebbeans/blob/12873ed083df9986e82d2f84a423ea50053672c8/webbeans-impl/src/main/java/org/apache/webbeans/portable/ProviderBasedProducer.java#L56-L61]
> {code:java}
> ClassLoader loader = returnType.getClassLoader();
> if (loader == null)
> {
> loader = WebBeansUtil.getCurrentClassLoader();
> }
> Class<T> proxyClass = proxyFactory.createProxyClass(loader, returnType);
> {code}
> Which will result in a stack trace similar to this:
> {code:java}
> java.lang.ClassNotFoundException:
> org.apache.webbeans.proxy.OwbNormalScopeProxy
> at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> at java.lang.ClassLoader.defineClass1(Native Method)
> at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
> at java.lang.ClassLoader.defineClass(ClassLoader.java:642)
> at sun.reflect.GeneratedMethodAccessor37.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.apache.webbeans.proxy.Unsafe.defineAndLoadClass(Unsafe.java:121)
> at
> org.apache.webbeans.proxy.AbstractProxyFactory.createProxyClass(AbstractProxyFactory.java:249)
> at
> org.apache.webbeans.proxy.AbstractProxyFactory.createProxyClass(AbstractProxyFactory.java:223)
> at
> org.apache.webbeans.proxy.NormalScopeProxyFactory.createProxyClass(NormalScopeProxyFactory.java:271)
> at
> org.apache.webbeans.portable.ProviderBasedProducer.produce(ProviderBasedProducer.java:61)
> at
> org.apache.webbeans.portable.AbstractProducer.produce(AbstractProducer.java:134)
> at
> org.apache.webbeans.component.AbstractOwbBean.create(AbstractOwbBean.java:122)
> at
> org.apache.webbeans.context.DependentContext.getInstance(DependentContext.java:68)
> at org.apache.webbeans.context.AbstractContext.get(AbstractContext.java:125)
> at
> org.apache.webbeans.container.BeanManagerImpl.getReference(BeanManagerImpl.java:813)
> at
> org.apache.webbeans.container.BeanManagerImpl.getInjectableReference(BeanManagerImpl.java:673)
> at
> org.apache.webbeans.inject.AbstractInjectable.inject(AbstractInjectable.java:100)
> at
> org.apache.webbeans.inject.InjectableField.doInjection(InjectableField.java:65)
> at
> org.apache.webbeans.portable.InjectionTargetImpl.injectFields(InjectionTargetImpl.java:227)
> at
> org.apache.webbeans.portable.InjectionTargetImpl.inject(InjectionTargetImpl.java:213)
> at
> org.apache.webbeans.portable.InjectionTargetImpl.inject(InjectionTargetImpl.java:203)
> at
> org.apache.webbeans.component.AbstractOwbBean.create(AbstractOwbBean.java:126)
> at org.apache.webbeans.component.ManagedBean.create(ManagedBean.java:66)
> at
> org.apache.webbeans.context.creational.BeanInstanceBag.create(BeanInstanceBag.java:76)
> at
> org.apache.webbeans.context.AbstractContext.getInstance(AbstractContext.java:159)
> at org.apache.webbeans.context.AbstractContext.get(AbstractContext.java:125)
> at
> org.apache.webbeans.intercept.NormalScopedBeanInterceptorHandler.getContextualInstance(NormalScopedBeanInterceptorHandler.java:101)
> at
> org.apache.webbeans.intercept.RequestScopedBeanInterceptorHandler.getContextualInstance(RequestScopedBeanInterceptorHandler.java:76)
> at
> org.apache.webbeans.intercept.NormalScopedBeanInterceptorHandler.get(NormalScopedBeanInterceptorHandler.java:71)
> {code}
> It seems like there should be some validation that the marker interface is
> available from the loader class and then fall back to
> `WebBeansUtil.getCurrentClassLoader()`... (or maybe just always use that!)
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
