did you double check compile and runtime bytecode compatibility?

-    protected abstract Class getMarkerInterface();
+    protected abstract Class<?> getMarkerInterface();

Always have to think hard about those types of changes. Seen some unpleasant 
surprises in the past ;)

txs and LieGrue,
strub


> Am 04.06.2020 um 00:38 schrieb gerdo...@apache.org:
> 
> This is an automated email from the ASF dual-hosted git repository.
> 
> gerdogdu pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/openwebbeans.git
> 
> 
> The following commit(s) were added to refs/heads/master by this push:
>     new 91dcbf2  adding comments and cosmetic changes
>     new b6c1310  Merge branch 'master' of 
> https://github.com/apache/openwebbeans
> 91dcbf2 is described below
> 
> commit 91dcbf2484c7da9aeba9a90712a4a16f8438c84f
> Author: Gurkan Erdogdu <cgurkanerdo...@gmail.com>
> AuthorDate: Thu Jun 4 01:25:55 2020 +0300
> 
>    adding comments and cosmetic changes
> ---
> .../src/main/java/org/apache/webbeans/component/OwbBean.java         | 5 +++++
> .../main/java/org/apache/webbeans/proxy/AbstractProxyFactory.java    | 2 +-
> .../java/org/apache/webbeans/spi/ApplicationBoundaryService.java     | 2 +-
> 3 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git 
> a/webbeans-impl/src/main/java/org/apache/webbeans/component/OwbBean.java 
> b/webbeans-impl/src/main/java/org/apache/webbeans/component/OwbBean.java
> index 83173c7..2e859ca 100644
> --- a/webbeans-impl/src/main/java/org/apache/webbeans/component/OwbBean.java
> +++ b/webbeans-impl/src/main/java/org/apache/webbeans/component/OwbBean.java
> @@ -96,5 +96,10 @@ public interface OwbBean<T> extends Bean<T>
>      */
>     boolean isDependent();
> 
> +    
> +    /**
> +     * Gets the context instance in which this bean belongs to.
> +     * @return the {@link WebBeansContext} instance
> +     */
>     WebBeansContext getWebBeansContext();
> }
> diff --git 
> a/webbeans-impl/src/main/java/org/apache/webbeans/proxy/AbstractProxyFactory.java
>  
> b/webbeans-impl/src/main/java/org/apache/webbeans/proxy/AbstractProxyFactory.java
> index 2ec4daa..8934c59 100644
> --- 
> a/webbeans-impl/src/main/java/org/apache/webbeans/proxy/AbstractProxyFactory.java
> +++ 
> b/webbeans-impl/src/main/java/org/apache/webbeans/proxy/AbstractProxyFactory.java
> @@ -146,7 +146,7 @@ public abstract class AbstractProxyFactory
>     /**
>      * @return the marker interface which should be used for this proxy.
>      */
> -    protected abstract Class getMarkerInterface();
> +    protected abstract Class<?> getMarkerInterface();
> 
>     /**
>      * generate the bytecode for creating the instance variables of the class
> diff --git 
> a/webbeans-spi/src/main/java/org/apache/webbeans/spi/ApplicationBoundaryService.java
>  
> b/webbeans-spi/src/main/java/org/apache/webbeans/spi/ApplicationBoundaryService.java
> index 592d9f2..ac81045 100644
> --- 
> a/webbeans-spi/src/main/java/org/apache/webbeans/spi/ApplicationBoundaryService.java
> +++ 
> b/webbeans-spi/src/main/java/org/apache/webbeans/spi/ApplicationBoundaryService.java
> @@ -38,6 +38,6 @@ public interface ApplicationBoundaryService
>     /**
>      * @return the ClassLoader which shall get used to e.g. proxy that very 
> class.
>      */
> -    ClassLoader getBoundaryClassLoader(Class classToProxy);
> +    ClassLoader getBoundaryClassLoader(Class<?> classToProxy);
> 
> }
> 

Reply via email to