Well, I'm with Gurkan here. The more tests we have internally the better. TCK tests are fine, but if we move to a new TCK version then we might miss something. The TCKs are also not always perfect. We start OWB so fast that it doesn't make much difference.
LieGrue, strub > Am 05.06.2020 um 11:39 schrieb Romain Manni-Bucau <rmannibu...@gmail.com>: > > Well, it is also bad to x2 the test time cause we duplicated the TCK. > TCK are part of our test coverage and we must consider it as fully part of > our harnessing IMHO, in particular for such simple tests, this is why I > think we shouldnt generalize this practise. > > You last comment also makes me realizing we don't have an onboarding page > on our website (we just have https://openwebbeans.apache.org/community.html > right?). > I'm not sure writing a test is welcoming, in particular we our testing > stack. > I also know as a starter it is very frustrating to do so because you > basically did nothing for the project until you increase test covering - > and we are not that bad on that already + it can be hard ot review tck > suite upfront. It is also something you can trivially do on your github (or > locally) to play with the project these days. > We should probably try to define some guidelines around how to help. > Out of my head I know doc can be something help would be very welcomed, SPI > doc can be enhanced a lot in particular, ecosystem integrations and doc are > things we can be better (for instance it is not obvious we run on graalvm - > even if there are some limitations). And we should probably flag/tag some > jira ticket as "beginner-friendly" (or a better named tag). This sounds a > better welcoming path to me, like "contribute something real" and "make the > project move forward". > > wdyt? > > Romain Manni-Bucau > @rmannibucau <https://twitter.com/rmannibucau> | Blog > <https://rmannibucau.metawerx.net/> | Old Blog > <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > <https://www.packtpub.com/application-development/java-ee-8-high-performance> > > > Le ven. 5 juin 2020 à 10:38, Gurkan Erdogdu <cgurkanerdo...@gmail.com> a > écrit : > >> One more thing: All new incomers to the project are invited to start with >> adding a simple test like this. >> >> On Fri, Jun 5, 2020 at 11:34 AM Gurkan Erdogdu <cgurkanerdo...@gmail.com> >> wrote: >> >>> Hey Romain >>> In fact, this is our internal test suite not the TCK. So, it is a good >>> idea to have internal tests to cover lots of spec requirements. >>> Regards. >>> Gurkan >>> >>> On Fri, Jun 5, 2020 at 8:52 AM Romain Manni-Bucau <rmannibu...@gmail.com >>> >>> wrote: >>> >>>> For what is worth: this is tested in TCK already >>>> (RestrictedManagedBeanTest I >>>> think) in an user facing way - i e CDI exception, not our internal OWB >> one >>>> which does not have to be stable. >>>> Don't know if we need to duplicate it - guess this one is fine cause >> fast >>>> but thought I should mention it. >>>> >>>> Romain Manni-Bucau >>>> @rmannibucau <https://twitter.com/rmannibucau> | Blog >>>> <https://rmannibucau.metawerx.net/> | Old Blog >>>> <http://rmannibucau.wordpress.com> | Github < >>>> https://github.com/rmannibucau> | >>>> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book >>>> < >>>> >> https://www.packtpub.com/application-development/java-ee-8-high-performance >>>>> >>>> >>>> >>>> ---------- Forwarded message --------- >>>> De : <gerdo...@apache.org> >>>> Date: jeu. 4 juin 2020 à 22:57 >>>> Subject: [openwebbeans] branch master updated: adding a test for testing >>>> the Typed annotation with wrong value >>>> To: comm...@openwebbeans.apache.org <comm...@openwebbeans.apache.org> >>>> >>>> >>>> This is an automated email from the ASF dual-hosted git repository. >>>> >>>> gerdogdu pushed a commit to branch master >>>> in repository https://gitbox.apache.org/repos/asf/openwebbeans.git >>>> >>>> >>>> The following commit(s) were added to refs/heads/master by this push: >>>> new 6de6f20 adding a test for testing the Typed annotation with >>>> wrong >>>> value >>>> 6de6f20 is described below >>>> >>>> commit 6de6f200f0817fc8028017800e5fdcf490496a9a >>>> Author: Gurkan Erdogdu <cgurkanerdo...@gmail.com> >>>> AuthorDate: Thu Jun 4 23:57:26 2020 +0300 >>>> >>>> adding a test for testing the Typed annotation with wrong value >>>> --- >>>> .../webbeans/test/injection/typed/NotInTyped.java | 26 >> +++++++++++++++++ >>>> .../test/injection/typed/NotInTypedTest.java | 34 >>>> ++++++++++++++++++++++ >>>> 2 files changed, 60 insertions(+) >>>> >>>> diff --git >>>> >>>> >> a/webbeans-impl/src/test/java/org/apache/webbeans/test/injection/typed/NotInTyped.java >>>> >>>> >> b/webbeans-impl/src/test/java/org/apache/webbeans/test/injection/typed/NotInTyped.java >>>> new file mode 100644 >>>> index 0000000..d5d265e >>>> --- /dev/null >>>> +++ >>>> >>>> >> b/webbeans-impl/src/test/java/org/apache/webbeans/test/injection/typed/NotInTyped.java >>>> @@ -0,0 +1,26 @@ >>>> +/* >>>> + * Licensed to the Apache Software Foundation (ASF) under one >>>> + * or more contributor license agreements. See the NOTICE file >>>> + * distributed with this work for additional information >>>> + * regarding copyright ownership. The ASF licenses this file >>>> + * to you under the Apache License, Version 2.0 (the >>>> + * "License"); you may not use this file except in compliance >>>> + * with the License. You may obtain a copy of the License at >>>> + * >>>> + * http://www.apache.org/licenses/LICENSE-2.0 >>>> + * >>>> + * Unless required by applicable law or agreed to in writing, >>>> + * software distributed under the License is distributed on an >>>> + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY >>>> + * KIND, either express or implied. See the License for the >>>> + * specific language governing permissions and limitations >>>> + * under the License. >>>> + */ >>>> +package org.apache.webbeans.test.injection.typed; >>>> + >>>> +import javax.enterprise.inject.Typed; >>>> + >>>> +@Typed(Raven.class) >>>> +public class NotInTyped implements Bird{ >>>> + >>>> +} >>>> diff --git >>>> >>>> >> a/webbeans-impl/src/test/java/org/apache/webbeans/test/injection/typed/NotInTypedTest.java >>>> >>>> >> b/webbeans-impl/src/test/java/org/apache/webbeans/test/injection/typed/NotInTypedTest.java >>>> new file mode 100644 >>>> index 0000000..97cbdb3 >>>> --- /dev/null >>>> +++ >>>> >>>> >> b/webbeans-impl/src/test/java/org/apache/webbeans/test/injection/typed/NotInTypedTest.java >>>> @@ -0,0 +1,34 @@ >>>> +/* >>>> + * Licensed to the Apache Software Foundation (ASF) under one >>>> + * or more contributor license agreements. See the NOTICE file >>>> + * distributed with this work for additional information >>>> + * regarding copyright ownership. The ASF licenses this file >>>> + * to you under the Apache License, Version 2.0 (the >>>> + * "License"); you may not use this file except in compliance >>>> + * with the License. You may obtain a copy of the License at >>>> + * >>>> + * http://www.apache.org/licenses/LICENSE-2.0 >>>> + * >>>> + * Unless required by applicable law or agreed to in writing, >>>> + * software distributed under the License is distributed on an >>>> + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY >>>> + * KIND, either express or implied. See the License for the >>>> + * specific language governing permissions and limitations >>>> + * under the License. >>>> + */ >>>> +package org.apache.webbeans.test.injection.typed; >>>> + >>>> +import org.apache.webbeans.exception.WebBeansConfigurationException; >>>> +import org.apache.webbeans.test.AbstractUnitTest; >>>> +import org.junit.Test; >>>> + >>>> +public class NotInTypedTest extends AbstractUnitTest >>>> +{ >>>> + >>>> + @Test(expected = WebBeansConfigurationException.class) >>>> + public void testNotInTypedMustThrowException() >>>> + { >>>> + startContainer(Bird.class, Raven.class, NotInTyped.class); >>>> + } >>>> + >>>> +} >>>> >>> >>> >>> -- >>> Gurkan Erdogdu >>> http://gurkanerdogdu.blogspot.com >>> >> >> >> -- >> Gurkan Erdogdu >> http://gurkanerdogdu.blogspot.com >>
