rmannibucau commented on a change in pull request #28:
URL: https://github.com/apache/openwebbeans/pull/28#discussion_r439807070
##########
File path: webbeans-junit5/src/main/java/org/apache/openwebbeans/junit5/Cdi.java
##########
@@ -80,6 +80,11 @@
*/
boolean disableDiscovery() default false;
+ /**
+ * @return {@code true} to enable JUnit parameter resolution with CDI
beans or {@code false} otherwise.
+ */
+ boolean injectParameters() default true;
Review comment:
I have several extensions doing a cdi lookup themselves with custom
rules. This impl breaks it until I disable the feature. Same happens with
framework having an IoC abstraction (often cdi/spring/guice) where the lookup
is done internally in the extension - going through the IoC abstraction.
I wouldnt say it is 50% of tests but likely 10% where it can hit and as
mentionned supporting it is almost just one qualifier for us so it is worth it.
That said I'm happy to do it after your PR is merged if you don't want to do it
in this PR too, just let me know the status ;).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
