> On Mar 15, 2021, at 2:16 PM, David Blevins <david.blev...@gmail.com> wrote: > >> On Mar 15, 2021, at 9:27 AM, Romain Manni-Bucau <rmannibu...@gmail.com> >> wrote: >> >> Hi, >> >> Added a configuration for the packages - since we can hit that with some >> "specific" jars and some signed ones: >> https://issues.apache.org/jira/browse/OWB-1377 >> Didn't get a change to run TCK setup but proxied the jakarta package >> several times so if anyone has enough resources to work on a reproducer I >> would be happy to refine this particular case if needed. >> In the mean time I guess tomee can set up the configuration in >> conf/system.properties and maybe fix its shade. > > I tried this flag out locally and it appears to work, so I've uploaded new > snapshots and have kicked off a full run and will report back. > > Interestingly, it worked locally now without the flag so it appears something > related might have been fixed in one of the changes over the weekend. After > the above run is done, I'll do another with the flag off. If it works > equally well, I'll also report as if it's fine it's probably better to delete > the flag. > > Definitely, it's most ideal if no flag is needed as we are producing > *-jakarta.jars and best case scenario is they work without any needed flags.
It does appear that after this weekend's changes things now work with or without this new flag. Jakarta EE 9 test results are 32142 passing with the flag and 32140 without the flag. The results after the OWB upgrade and prior to this weekend's changes were less than 10k passing. I'd recommend doing the release as things are now and then maybe we should remove the flag just so we have less to maintain. Once flags like this are out there for a year, it's impossible to ever delete them as you never know who is using them or how they'll be impacted. -David
smime.p7s
Description: S/MIME cryptographic signature
