[
https://issues.apache.org/jira/browse/OWB-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308585#comment-17308585
]
Romain Manni-Bucau commented on OWB-1381:
-----------------------------------------
[~tandraschko] fact is the caller can do the caching and in terms of number it
is like at least hundreds of miss entries for a standard jsf app (only) which
are fully useless and shouldn't exist since the call is invalid + the caller
will need to cache it anyway for perf reasons (even if we optimize getRef we
don't want to enter into it each time), this is why i think the caller must be
fixed, because the owb "fix" is actually a workaround for any app using this
pattern - I didn't find a single valid use case for it, even ear case, but
happy to review if you have some you can share.
> Empty resolvedComponents not cached in InjectionResolver
> --------------------------------------------------------
>
> Key: OWB-1381
> URL: https://issues.apache.org/jira/browse/OWB-1381
> Project: OpenWebBeans
> Issue Type: Improvement
> Components: Injection and Lookup
> Affects Versions: 2.0.21
> Reporter: Vladimir Dvorak
> Priority: Minor
>
> YourKit performance analyzer showed that the call of
> InjectionResolver.implResolveByType() could be pretty expensive. The method
> uses caching except the case when no component is found. This case is skipped
> at the end of the metod as is visible at:
> [https://github.com/apache/openwebbeans/blob/master/webbeans-impl/src/main/java/org/apache/webbeans/container/InjectionResolver.java#L559]
>
> In our case we have huge JSF page with a lot of JSF Converters classes, that
> form injectionPointType input argument of the method. It is not clear why JSF
> converters are not found...
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
