[ 
https://issues.apache.org/jira/browse/OWB-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308593#comment-17308593
 ] 

Thomas Andraschko edited comment on OWB-1381 at 3/25/21, 11:13 AM:
-------------------------------------------------------------------

Caching it in JSF isnt that easy. Converter/Validators are created each time 
used and doesnt have a lifecycle.
And as we already have cache at this place in OWB, i think we could just 
enhance this a bit. This would automatically make it better for 
MyFaces/Mojarra/DeltaSpike users and should only be a small change.



was (Author: tandraschko):
Caching it in JSF isnt that easy. Converter/Validators are created each time 
used. 
And as we already have cache at this place in OWB, i think we could just 
enhance this a bit. This would automatically make it better for 
MyFaces/Mojarra/DeltaSpike users and should only be a small change.


> Empty resolvedComponents not cached in InjectionResolver
> --------------------------------------------------------
>
>                 Key: OWB-1381
>                 URL: https://issues.apache.org/jira/browse/OWB-1381
>             Project: OpenWebBeans
>          Issue Type: Improvement
>          Components: Injection and Lookup
>    Affects Versions: 2.0.21
>            Reporter: Vladimir Dvorak
>            Priority: Minor
>
> YourKit performance analyzer showed that the call of 
> InjectionResolver.implResolveByType() could be pretty expensive. The method 
> uses caching except the case when no component is found. This case is skipped 
> at the end of the metod as is visible at:
> [https://github.com/apache/openwebbeans/blob/master/webbeans-impl/src/main/java/org/apache/webbeans/container/InjectionResolver.java#L559]
>  
> In our case we have huge JSF page with a lot of JSF Converters classes, that 
> form injectionPointType input argument of the method. It is not clear why JSF 
> converters are not found...
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to