rmannibucau commented on a change in pull request #33:
URL: https://github.com/apache/openwebbeans/pull/33#discussion_r629337241
##########
File path:
webbeans-impl/src/main/resources/META-INF/openwebbeans/openwebbeans.properties
##########
@@ -220,6 +220,7 @@ org.apache.webbeans.scanExclusionPaths=/jre/lib, \
/jsp-api, \
/myfaces-api, \
/myfaces-impl, \
+ /jakarta.faces, \
Review comment:
my 2cts would be that any exclude is wong but generally works until a
naming breaks it
afaik jakarta.faces does not need to be scanned so i wouldnt make it
specific by itself but also because it would be a jakarta/javax change (guess
we missed that exclusion when we made jakarta package integration for
openwebbeans since we don't use mojarra in the core project)
it is kind of consistent with your mention, javax.faces was ok being
excluded so jakarta.faces should be.
side note (not sure it is clear): excluded means not scanned by OWB but an
extension can still add beans, it is not "fully ignore this jar", just "don't
look for beans through its .class").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
