rmannibucau commented on a change in pull request #34: URL: https://github.com/apache/openwebbeans/pull/34#discussion_r632489637
########## File path: webbeans-web/src/main/java/org/apache/webbeans/web/context/WebContextsService.java ########## @@ -593,9 +593,17 @@ protected boolean sessionIsExpiring(HttpSession session) int maxInactiveInterval = session.getMaxInactiveInterval(); if (maxInactiveInterval > 0) { - long inactiveSince = TimeUnit.MILLISECONDS.toSeconds(System.currentTimeMillis() - session.getLastAccessedTime()); - if (inactiveSince >= maxInactiveInterval) + try { + long inactiveSince = TimeUnit.MILLISECONDS.toSeconds(System.currentTimeMillis() - session.getLastAccessedTime()); + if (inactiveSince >= maxInactiveInterval) + { + return true; + } + } + catch (IllegalStateException e) + { + // Jetty will throw an ISE if you attempt to query the last accessed time of a session that is being invalidated return true; Review comment: @tandraschko I'd prefer to have a custom extended listener or service in jetty module with a property (from openwebbeans.properties/OpenWebBeansConfiguration) to enable/disable it by conf. In main code (generic web module) it can hurt all other containers since it is about hiding a bug and not swallowing an expected exception. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org