Hi JL, It looks weird because we already had a fallback to use the constructor - and BTW i'm not sure the commented part of the test should be. So this shouldn't help TomEE.
Do you have a test where this change helps? side note: we likely don't want to break the SPI since it is an user facing part. I saw you mentionned a default method but we should probably check we need it at all before (not sure how tomee is different there on java 17 since the extension points were already set up IIRC). Happy to discuss on slack if it is easier - know mails can be complicated for such things ;). Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <https://www.packtpub.com/application-development/java-ee-8-high-performance> Le mer. 6 oct. 2021 à 10:14, Jean-Louis MONTEIRO <jeano...@gmail.com> a écrit : > Thanks Thomas > > I've created https://issues.apache.org/jira/browse/OWB-1392 > And I pushed > > https://github.com/apache/openwebbeans/commit/2af6184ee5ec6b474f037b3c5768c82bba136722 > > I'd appreciate feedback, review and comments. Should have created a PR > sorry. > Functionally, it's the same as previously, but it allows TomEE to override > the instanciation part to be consistent. > > > Le mar. 5 oct. 2021 à 23:11, Thomas Andraschko < > andraschko.tho...@gmail.com> > a écrit : > > > AFAIK we didnt start the process yet, so we can wait for your fix > > > > Am Di., 5. Okt. 2021 um 22:27 Uhr schrieb Jean-Louis MONTEIRO < > > jeano...@gmail.com>: > > > > > I have an issue with OWB in TomEE under JDK 17 > > > I think I can workaround it, but I'd need a small change in OWB. > > > > > > Can we reroll it after my fix? > > > > > > Le lun. 4 oct. 2021 à 09:29, Jean-Baptiste Onofré <j...@nanthrax.net> a > > > écrit : > > > > > > > +1 > > > > > > > > Regards > > > > JB > > > > > > > > On 03/10/2021 20:56, Romain Manni-Bucau wrote: > > > > > Hi all, > > > > > > > > > > We fixed a few issues: > > > > > > > > > > PTKeySummaryAssigneeStatus > > > > > [image: Major] [image: Bug] OWB-1298 > > > > > <https://issues.apache.org/jira/browse/OWB-1298> > > WebsocketUserManager > > > > > ambigious resolution Jakarta Faces > > > > > <https://issues.apache.org/jira/browse/OWB-1298> Unassigned > RESOLVED > > > > > [image: Major] [image: Bug] OWB-1387 > > > > > <https://issues.apache.org/jira/browse/OWB-1387> > > > > > @Destroyed(ApplicationScoped.class) > > > > > not thrown when @Destroyed(RequestScoped.class) exists > > > > > <https://issues.apache.org/jira/browse/OWB-1387> Arne Limburg > > > > > <https://issues.apache.org/jira/secure/ViewProfile.jspa?name=arne> > > > > CLOSED > > > > > [image: Major] [image: Improvement] OWB-1389 > > > > > <https://issues.apache.org/jira/browse/OWB-1389> Remove destroyed > > > > instance > > > > > from memory <https://issues.apache.org/jira/browse/OWB-1389> Mark > > > > Struberg > > > > > < > > https://issues.apache.org/jira/secure/ViewProfile.jspa?name=struberg> > > > > > RESOLVED > > > > > [image: Major] [image: Task] OWB-1390 > > > > > <https://issues.apache.org/jira/browse/OWB-1390> support > > > > > javax.enterprise.inject.scan.implicit property > > > > > <https://issues.apache.org/jira/browse/OWB-1390> Romain > Manni-Bucau > > > > > < > > > > > > > > > > https://issues.apache.org/jira/secure/ViewProfile.jspa?name=romain.manni-bucau > > > > > > > > > > RESOLVED > > > > > [image: Major] [image: Task] OWB-1391 > > > > > <https://issues.apache.org/jira/browse/OWB-1391> > > > > AbstractMetaDataDiscovery > > > > > ignores classpath entries starting with a common path > > > > > <https://issues.apache.org/jira/browse/OWB-1391> Romain > Manni-Bucau > > > > > < > > > > > > > > > > https://issues.apache.org/jira/secure/ViewProfile.jspa?name=romain.manni-bucau > > > > > > > > > > RESOLVED > > > > > > > > > > I know Thomas can await a few of them so wonder if we should > trigger > > a > > > > > release next week (starting on the 4th) or in the following days. > > > > > > > > > > I'd just like to highlight the 1391 changes the way we ignore > > > duplicated > > > > > jars/folders in in the classpath so can be worth some testing. > > > > > > > > > > No issue to delay from some days the release if it helps. > > > > > > > > > > Side note for our beloved tomee siblings: this shouldn't impact you > > > since > > > > > you don't reuse that scanning/lifecycle logic so should be a "noop > > > > release" > > > > > for you. > > > > > > > > > > Romain Manni-Bucau > > > > > @rmannibucau <https://twitter.com/rmannibucau> | Blog > > > > > <https://rmannibucau.metawerx.net/> | Old Blog > > > > > <http://rmannibucau.wordpress.com> | Github < > > > > https://github.com/rmannibucau> | > > > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > > > > > < > > > > > > > > > > https://www.packtpub.com/application-development/java-ee-8-high-performance > > > > > > > > > > > > > > > > > > > > > > > -- > > > Jean-Louis > > > > > > > > -- > Jean-Louis >
