tysonnorris commented on a change in pull request #2246: To resolve #2245 -
optimize container removal
URL:
https://github.com/apache/incubator-openwhisk/pull/2246#discussion_r116613440
##########
File path:
core/invoker/src/main/scala/whisk/core/containerpool/ContainerPool.scala
##########
@@ -192,13 +192,14 @@ object ContainerPool {
* takes away one of their containers iff the namespace placing the new
job is
* not already the most consuming one.
*
- * @param namespace the namespace that wants to get a container
+ * @param action the action that wants to get a container
* @param pool a map of all containers in the pool
* @return a container to be removed iff found
*/
- def remove[A](invocationNamespace: EntityName, pool: Map[A, WorkerData]):
Option[A] = {
+ def remove[A](action: ExecutableWhiskAction, pool: Map[A, WorkerData]):
Option[A] = {
Review comment:
@rabbah I don't see this (isolation by subject) implemented the new
ContainerPool currently, I expect it would need to be added to WarmedData -
should I add that as part of this PR, or separate?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
