markusthoemmes commented on a change in pull request #2246: To resolve #2245 -
optimize container removal
URL:
https://github.com/apache/incubator-openwhisk/pull/2246#discussion_r116658489
##########
File path:
tests/src/test/scala/whisk/core/containerpool/test/ContainerPoolTests.scala
##########
@@ -68,7 +69,9 @@ class ContainerPoolTests extends
TestKit(ActorSystem("ContainerPool"))
val memoryLimit = 256.MB
val invocationNamespace = EntityName("invocationSpace")
+ val invocationNamespace2 = EntityName("invocationSpace2")
val action = ExecutableWhiskAction(EntityPath("actionSpace"),
EntityName("actionName"), exec)
+ val action2 = ExecutableWhiskAction(EntityPath("actionSpace"),
EntityName("actionName2"), exec)
Review comment:
Same comment on naming. You can also write:
```
val differentAction = action.copy(name = EntityName("actionName2"))
```
Makes it a bit more apparent that you just change the name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
