Hi Michele, thanks for the PRs. May I suggest breaking this large PR against this repo https://github.com/apache/incubator-openwhisk-runtime-go into several smaller and incremental ones?
1. an initial commit, adding contributing doc, license, gradle structure and ancillary files 2. the go proxy 3. the go action support 4. the swift support This is so we can get commits in more quickly and focus the review on the critical parts vs the 2500+ lines of added code much of which is boiler plate we can skip. I made an initial pass moments ago just to understand the overall structure. Also Thanks to Vadim who's looked through the go logic already. If you break the PR up, we can isolate the reviewers to the relevant people and move a bit more quickly on integration. -r On Fri, Mar 16, 2018 at 4:22 AM, Michele Sciabarra <[email protected]> wrote: > Well, here is a more detailed status update: > > Released an implementation of Go Actions: submitted a huge PR here: > > https://github.com/apache/incubator-openwhisk-runtime-go > > basically handing over the content of > > https://github.com/sciabarracom/incubator-openwhisk-runtime-go > > Now working on the swift actions: > > https://github.com/apache/incubator-openwhisk-runtime-swift > > to use my Go based proxy. > > In the process I need to implement source support, for both whisk and go > (so far Go runtime is binary only). > > > -- > Michele Sciabarra > [email protected] > > On Fri, Mar 16, 2018, at 8:58 AM, Bertrand Delacretaz wrote: > > Hi, > > > > On Fri, Mar 16, 2018 at 8:56 AM, Michele Sciabarra > > <[email protected]> wrote: > > > ..is not the mailing supposed to be used for communicating this sort > of things with the community?... > > > > That's the role of this list indeed! > > > > As OpenWhisk has many Git repositories I think it's great to include > > the URLs of what you're talking about - it helps people like me who > > are trying to generally keep up with what's happening, without being > > closely involved in anything in particular (so far ;-) > > > > -Bertrand >
