Thanks Christian +2 This PR in addition of fixing the bug it also adds an improvement that the limit size is not longer hardcoded and is now a configuration setting that the operator deploying can customize.
- Carlos Santana @csantanapr > On Jul 6, 2018, at 7:44 AM, Christian Bickel <[email protected]> wrote: > > Hey, > > a few days a go we found a little bug: > > On creating an action, the code is sent to the controller. Afterwards > the controller checks, that the code is not too big. If the code > itself is sent directly (e.g. uploading a single `.js` file), the > limit is 48MB (today). > If an archive is uploaded, it will be encoded with base64. The problem > here is, that base64 has an overhead of 1/3. This means, if you have > an archive, that has a size of e.g. 45MB, 60MB will be sent to the > controller. So the request will be rejected. This is not expected for > the user, as a limit of 48MB was proposed to him. > > I opened a PR to fix this behaviour: > https://github.com/apache/incubator-openwhisk/pull/3835 > > As this change, potentially raises the action size in the database, I > wanted to ask if anyone has any concerns with this PR. > > If not, I will go forward with it. > > Greetings
