There are some license and formatting issues that will need to be fixed
before we can make a release.  I don't think there is anything deep, but
we'll need some fixups to get a clean run from our 'rcverify.sh` tool [1]
I am working on making it pass as part of my PR.

Question: The "executable files" check does complain about one executable file 
- "cli.js".  However this has to be executable in the sources, as this is the 
entry point for wskdebug as a node/npm cli. It is set as the bin file in npm 
[2] [3]. You also want this in the git sources to make local development via 
npm link work, so delaying setting of the exec flag on npm publish would not be 
a solution. (No linking in Javascript/Nodejs :-))

Can there be an exclusion list? Change rcverify.sh directly?

[1]
https://github.com/apache/openwhisk-release/blob/master/tools/rcverify.sh
[2] 
https://github.com/apache/openwhisk-wskdebug/blob/master/package.json#L18-L19
[3] https://docs.npmjs.com/files/package.json#bin

Cheers,
Alex


Reply via email to